fix: More accurate source locations for method names. #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varungandhi-src
force-pushed
the
vg/structs
branch
from
3294aa1 to
0367e8a
Compare
varungandhi-src
force-pushed
the
vg/structs
branch
from
e7a77b8 to
9e146e1
Compare
varungandhi-src
force-pushed
the
vg/structs
branch
from
9e146e1 to
35b3c8b
Compare
varungandhi-src
commented
Sep 6, 2022
Comment on lines
+5
to
+6
| alias_method :am_aaa, :aaa | ||
| alias :a_aaa :aaa |
There was a problem hiding this comment.
I've filed #93 for this.
varungandhi-src
commented
Sep 6, 2022
Comment on lines
+6
to
+8
| delegate :ball, to: :thing, private: true, allow_nil: true | ||
| # ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ reference [..] Proc# | ||
| # ^^^^^ definition [..] MethodNameManipulation#ball(). |
There was a problem hiding this comment.
Missing a reference for :thing, filed #95.
varungandhi-src
commented
Sep 6, 2022
Comment on lines
+19
to
+26
| from 1..2, :foo | ||
| # ^^^^ definition [..] Flatfile#`foo=`(). | ||
| # ^^^^ definition [..] Flatfile#foo(). | ||
| pattern(/A-Za-z/, :bar) | ||
| # ^^^^^^^^ reference [..] Regexp# | ||
| # ^^^^ definition [..] Flatfile#bar(). | ||
| # ^^^^ definition [..] Flatfile#`bar=`(). | ||
| field :baz |
There was a problem hiding this comment.
These are missing references for 'from', 'pattern' and 'field', filed #96.
varungandhi-src
commented
Sep 6, 2022
Comment on lines
+56
to
+62
| instance_helper | ||
| end | ||
|
|
||
| it 'can read foo' do | ||
| # ^^^^^^^^^^^^^^ definition [..] MyTest#`<it 'can read foo'>`(). | ||
| T.assert_type!(@foo, Integer) | ||
| instance_helper |
There was a problem hiding this comment.
Missing references for instance_helper here, filed #94.
varungandhi-src
commented
Sep 6, 2022
| def assert(test) | ||
| # ^^^^^^ definition [..] MyTest#assert(). | ||
| # ^^^^ definition local 1~#2774883451 | ||
| test ? true : false |
There was a problem hiding this comment.
Missing a reference for the parameter here, filed #97.
varungandhi-src
commented
Sep 6, 2022
|
|
||
| setup do | ||
| # ^^^^^ definition [..] MyTest#initialize(). | ||
| @a = T.let(1, Integer) |
There was a problem hiding this comment.
Missing a definition/reference here, filed #97.
varungandhi-src
commented
Sep 6, 2022
varungandhi-src
changed the title
Closed
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
def_delegator.Motivation
Fixes #49, make progress towards #1.
Test plan
Updated existing tests, added new test for structs