Skip to content

test: Add missing extend T::Sig. #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2022
Merged

test: Add missing extend T::Sig. #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/scip/testdata/hoverdocs.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@

# Class doc comment
class C1
extend T::Sig

def m1
end

Expand Down Expand Up @@ -50,6 +52,8 @@ class C3

# This module is nested inside M1
module M2
extend T::Sig

# This method is inside M1::M2
sig { returns(T::Boolean) }
def n1
Expand Down Expand Up @@ -77,6 +81,8 @@ def f2
def f3 # undocumented global function
end

extend T::Sig

sig { returns(T::Integer) }
def f4 # another undocumented global function
return 10
Expand Down
21 changes: 21 additions & 0 deletions test/scip/testdata/hoverdocs.snapshot.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ class C1
# | ```
# documentation
# | Class doc comment
extend T::Sig
# ^ reference [..] T#
# ^^^ reference [..] T#Sig#

def m1
# ^^^^^^ definition [..] C1#m1().
# documentation
Expand All @@ -21,6 +25,7 @@ def m1

sig { returns(T::Boolean) }
# ^^^ reference [..] Sorbet#Private#Static#<Class:ResolvedSig>#sig().
# ^^^^^^^ reference [..] T#Private#Methods#DeclBuilder#returns().
# ^ reference [..] T#
# ^^^^^^^ reference [..] T#Boolean.
# ^^^^^^^^^^ reference [..] Sorbet#Private#Static#ResolvedSig#
Expand All @@ -36,9 +41,11 @@ def m2

sig { params(C, T::Boolean).returns(T::Boolean) }
# ^^^ reference [..] Sorbet#Private#Static#<Class:ResolvedSig>#sig().
# ^^^^^^ reference [..] T#Private#Methods#DeclBuilder#params().
# ^ reference [..] T.untyped#
# ^ reference [..] T#
# ^^^^^^^ reference [..] T#Boolean.
# ^^^^^^^ reference [..] T#Private#Methods#DeclBuilder#returns().
# ^ reference [..] T#
# ^^^^^^^ reference [..] T#Boolean.
# ^^^^^^^^^^ reference [..] Sorbet#Private#Static#ResolvedSig#
Expand Down Expand Up @@ -89,6 +96,7 @@ def m4(xs)
# ...doc comment
sig { returns(T::Boolean) }
# ^^^ reference [..] Sorbet#Private#Static#<Class:ResolvedSig>#sig().
# ^^^^^^^ reference [..] T#Private#Methods#DeclBuilder#returns().
# ^ reference [..] T#
# ^^^^^^^ reference [..] T#Boolean.
# ^^^^^^^^^^ reference [..] Sorbet#Private#Static#ResolvedSig#
Expand All @@ -109,9 +117,11 @@ def m5
# ...one more doc comment
sig { params(C, T::Boolean).returns(T::Boolean) }
# ^^^ reference [..] Sorbet#Private#Static#<Class:ResolvedSig>#sig().
# ^^^^^^ reference [..] T#Private#Methods#DeclBuilder#params().
# ^ reference [..] T.untyped#
# ^ reference [..] T#
# ^^^^^^^ reference [..] T#Boolean.
# ^^^^^^^ reference [..] T#Private#Methods#DeclBuilder#returns().
# ^ reference [..] T#
# ^^^^^^^ reference [..] T#Boolean.
# ^^^^^^^^^^ reference [..] Sorbet#Private#Static#ResolvedSig#
Expand Down Expand Up @@ -182,9 +192,14 @@ module M2
# | ```
# documentation
# | This module is nested inside M1
extend T::Sig
# ^ reference [..] T#
# ^^^ reference [..] T#Sig#

# This method is inside M1::M2
sig { returns(T::Boolean) }
# ^^^ reference [..] Sorbet#Private#Static#<Class:ResolvedSig>#sig().
# ^^^^^^^ reference [..] T#Private#Methods#DeclBuilder#returns().
# ^ reference [..] T#
# ^^^^^^^ reference [..] T#Boolean.
# ^^^^^^^^^^ reference [..] Sorbet#Private#Static#ResolvedSig#
Expand Down Expand Up @@ -235,6 +250,7 @@ def f1
# Yet another global function
sig { returns(T::Integer) }
#^^^ reference [..] Sorbet#Private#Static#<Class:ResolvedSig>#sig().
# ^^^^^^^ reference [..] T#Private#Methods#DeclBuilder#returns().
# ^ reference [..] T#
# ^^^^^^^ reference [..] T.untyped#
# ^^^^^^^^^^ reference [..] Sorbet#Private#Static#ResolvedSig#
Expand All @@ -259,8 +275,13 @@ def f3 # undocumented global function
#| ```
end

extend T::Sig
# ^ reference [..] T#
# ^^^ reference [..] T#Sig#

sig { returns(T::Integer) }
#^^^ reference [..] Sorbet#Private#Static#<Class:ResolvedSig>#sig().
# ^^^^^^^ reference [..] T#Private#Methods#DeclBuilder#returns().
# ^ reference [..] T#
# ^^^^^^^ reference [..] T.untyped#
# ^^^^^^^^^^ reference [..] Sorbet#Private#Static#ResolvedSig#
Expand Down