Skip to content

fix: Fix occurrences for field inheritance #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

varungandhi-src
Copy link
Contributor

@varungandhi-src varungandhi-src commented Sep 16, 2022

Motivation

Right now, go-to-def and find references doesn't quite work properly with inheritance. This is one step towards fixing that for fields. The current approach doesn't work for mixins, only for classes.

Misc TODO

  • Remove debugging print statements

Test plan

New tests for:

  • Instance variables
  • Class variables
  • Class instance variables

@varungandhi-src varungandhi-src force-pushed the vg/field-inheritance branch 2 times, most recently from 62a446a to 06565bf Compare September 19, 2022 02:00
@varungandhi-src varungandhi-src changed the title [WIP] fix: Fix occurrences for field inheritance fix: Fix occurrences for field inheritance Sep 19, 2022
Handles:
- Instance variables
- Class variables
- Class instance variables

Does not handle modules/mix-ins.
@varungandhi-src varungandhi-src mentioned this pull request Sep 19, 2022
57 tasks
@varungandhi-src varungandhi-src merged commit bfb2a29 into scip-ruby/master Sep 19, 2022
@varungandhi-src varungandhi-src deleted the vg/field-inheritance branch September 19, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant