-
Notifications
You must be signed in to change notification settings - Fork 32
Transition to Yarn Workspaces #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leeyi45
wants to merge
392
commits into
master
Choose a base branch
from
yarn-workspaces
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 45 commits
Commits
Show all changes
392 commits
Select commit
Hold shift + click to select a range
8e2507e
Make tests CI invariant for testing command
leeyi45 e9409bc
I give up the test is broken
leeyi45 d638ed0
Working version of migrated code
leeyi45 e8f650c
Make tests work with repotools
leeyi45 fd7bc7d
Fix workflow
leeyi45 3643979
Add lodash and node types
leeyi45 ecbc201
Change the git root functions to be constants
leeyi45 8da00d0
Another broken test fix
leeyi45 910d839
fix docs not building
leeyi45 9edff7c
Test that removing the preinstall script from the root package makes …
leeyi45 c25dd65
Fix incorrectly specified dependency
leeyi45 f79cc85
Test a new workflow
leeyi45 e7b1149
Enable corepack in new workflow
leeyi45 b3cbc39
Change node version for info action
leeyi45 ab4391f
Add the dependency install step
leeyi45 2cb5c5d
Use a limited install instead and temporarily disable main workflow
leeyi45 053772b
Fix wrong install command
leeyi45 914e1be
Update action to use the correct version of node
leeyi45 5cc2127
Does this work?
leeyi45 77caeca
Change workflow to return package names instead
leeyi45 fa31b81
Add to summary
leeyi45 cdae9a2
Forgor to write to the summary
leeyi45 3490671
Try actually doing something using this new workflow
leeyi45 6dc82ab
Try adding fromJSON
leeyi45 e72fa00
Output the [ackage's directory alongside its name
leeyi45 faf0ee9
Fix incorrect cd command
leeyi45 7242ea8
Try building tabs
leeyi45 4f5d137
Try something interesting....
leeyi45 b71bf0b
Ifx potential dev dependency not installing
leeyi45 21f5b97
Repotools still don't want to work properly
leeyi45 85773b0
Fix broken action paths
leeyi45 b08c46a
Just commit the built actions instead
leeyi45 3aee3e8
Minify the actions properly
leeyi45 d9a9034
turns out we just have to install the packages
leeyi45 61bd9ca
Fix the install-deps action being broken
leeyi45 7ffe200
Fix install-deps not installing buildtools
leeyi45 20fa7ad
Will manually compiling the buildtools work?
leeyi45 91fbea0
Idk man is this how caching works?
leeyi45 417cbd6
Is this how we cache?
leeyi45 241e08b
Just use key?
leeyi45 58cfaa1
Don't rebuild buildtools, just restore from the cache
leeyi45 087f3af
Will setting a default working directory work?
leeyi45 a2f5ad5
Turns out we'll probably need to restore the repotools too
leeyi45 791d757
Fix a buildtools gitignore?
leeyi45 3b30fb0
Fix incorrect working directory?
leeyi45 1642e4f
Add sparse checkout
leeyi45 95a6f16
Remove sparse-checkout
leeyi45 8947dd7
Switch back to the old workflow
leeyi45 1ebe352
yippee
leeyi45 728436d
Make pre-push hook executable
leeyi45 97e0112
Add yml linting
leeyi45 b235769
Change prepare scripts to postinstall scripts
leeyi45 169f161
Remove buildtools dependency on modules-lib
leeyi45 5e0461a
Workflow again.....
leeyi45 358c31d
Try again
leeyi45 561627c
pls work
leeyi45 4ea7757
Trying another fix
leeyi45 2ed0a62
Does this work?????
leeyi45 ca64d00
Fix broken pipe character
leeyi45 baaada2
Try and fix the git root path not working
leeyi45 17ed52e
I really don't know what is going on
leeyi45 fc696f2
now im really confused
leeyi45 6a0d7e0
Testing again
leeyi45 d2a719e
Is the check for changes function throwing an error?
leeyi45 9e7baf7
I think I figured it out
leeyi45 661dc91
Add formatting to the summary output
leeyi45 0d7735b
Check that the find package job produces appropriate outputs
leeyi45 92e5c92
Fix action.yml file not recording outputs
leeyi45 ed2beb0
Attempt 1 at creating workflows for tabs
leeyi45 174983c
Add postinstall scripts to bundles
leeyi45 ecf67f5
Fix things certain dependencies not being specified correctly
leeyi45 72fe640
Once again, fix more missing dependencies
leeyi45 9081a13
Add bundles to workflow file
leeyi45 82cf7f8
Fix missing dependencies again
leeyi45 ed773a3
Try out a new composite action
leeyi45 a01c1a0
Fix broken action not checking code out
leeyi45 bb0dbc1
Add required shell parameter
leeyi45 2db7fc2
Update incorrect action input name
leeyi45 8dbc63d
Fix init action not installing deps
leeyi45 7b8db40
Not me trying to see why this action doesn't work
leeyi45 4069d32
Fix incorrect keyword
leeyi45 b0eff8e
Not sure why playwright is being weird
leeyi45 64d0584
Checking again
leeyi45 843801c
Apparently github actions does weird things
leeyi45 49017ea
Patch uniqid to remove its node dependency
leeyi45 827d837
what's broken this time?
leeyi45 884487b
So why are the tests not running
leeyi45 9355d32
Try fixing the comparison checks again
leeyi45 42705ce
Fix whatever is broken
leeyi45 9100bbf
Add test dependencies to buildtools so that they're installed when te…
leeyi45 5ff41cc
Linting yml
leeyi45 be46185
Remove the old install-deps action
leeyi45 80449f1
Update the buildtools test
leeyi45 498e291
Add a static type file for lint plugin
leeyi45 c5cd95b
Fix broken lintplugin build
leeyi45 90714c3
Include peer dependencies as dev dependencies for lint plugin
leeyi45 387cbbe
Try fixing the communication bundle
leeyi45 575e7b4
Add test coverage testing to workflow
leeyi45 dcbfd54
Fix coverage reporters being broken
leeyi45 04aee64
Fix test timeouts again
leeyi45 7e93564
Add coverage provider to repotools
leeyi45 19611fa
Fix some broken linting and refactor test config to repotools
leeyi45 acf42e4
Add the new lint rule
leeyi45 df703d3
Forgot to add something to dev dependencies again.
leeyi45 51423c0
Resolve vite to the same version using resolutions
leeyi45 4b30c0f
Update github actions and docs
leeyi45 785a0e4
Update lint plugin
leeyi45 cebfeb7
Figure out what went wrong with the info action
leeyi45 c2ca1b9
Use yield instead of return
leeyi45 35d5f34
Add tests to the workflow
leeyi45 d075987
Need to change the test environment for the actions
leeyi45 ebb8d9f
Change how things are saved as artifacts
leeyi45 56f0246
Added building docs to bundle job
leeyi45 aab6c5d
Fix wrong command for bundles
leeyi45 b885d76
Allow TypeAliases to be exported but excluded from JSON output
leeyi45 aaf74f1
Update test for buildtools to account for TypeAliases
leeyi45 969e858
Add linting configs to the docs
leeyi45 01552b5
Try a new way for determining changes
leeyi45 c75f5ae
Fix missing name check
leeyi45 15c3d41
Fix issues with not skipping __
leeyi45 12da06a
Fix bundles and tabs package not being handled correctly
leeyi45 2b8b79e
Still trying to fix a broken check
leeyi45 434a37c
Needed to move the check to another function
leeyi45 c60359b
Put the check back in the previous place
leeyi45 4feea8c
Check was still broken
leeyi45 b5c9f21
Fix incorrect packages being displayed
leeyi45 67e50db
I missed an s
leeyi45 25ff249
Fix incorrect types being passed around
leeyi45 08a8f63
Fix maxdepth parameter not being checked properly
leeyi45 5f238b7
Use memoize to remove unnecessary calls to git
leeyi45 ac229bd
Mock memoize
leeyi45 f99658c
Try fix something that's broken
leeyi45 689fb24
Why is this stil broken :(
leeyi45 5411b28
Work please :(
leeyi45 20bf4dd
Fix package names being incorrect
leeyi45 21018aa
Finalize a topo sort algorithm to determine changes
leeyi45 a23afae
Figure out if docserver and devserver are being accurately represented
leeyi45 62b911f
Does comparing to a string value work?
leeyi45 82bca31
Add new linting rule and fix documentation being broken
leeyi45 0d54296
Remove a file that was accidentally committed
leeyi45 d80cf63
Fix missing type in manifest and mkdir call in manifest builder
leeyi45 385a3e5
Fix the still broken test
leeyi45 2abda8d
Fix tests not being compatible with Windows paths joining
leeyi45 b8d64b2
Try running library tests on windows-latest as well with the workflow
leeyi45 3bcfdd4
Update shell configuration for workflows
leeyi45 5242c61
Fix the OS comparison test
leeyi45 0bb7536
Fix shell not being input correctly into init action
leeyi45 40b979e
Will adding corepack to the PATH work?
leeyi45 2da6a75
Does enabling corepack after setting up node work?
leeyi45 955d30c
Still screwing around with corepack
leeyi45 a61c2bb
Try again with the other things
leeyi45 3156f2d
What happens if I -Force?
leeyi45 867c51d
Try a different corepack command
leeyi45 ac286a9
Try which
leeyi45 411654c
Fix issues on Windows
RichDom2185 1a98c97
More testing
leeyi45 b2387f6
Try hardcoding the yarn version
leeyi45 0698790
Just corepack install?
leeyi45 cd704d5
Would an npm install work?
leeyi45 d635892
I genuinely still don't know why powershell won't use yarn properly
leeyi45 92be334
Try something new with corepack enable
leeyi45 9a3df60
Fix docs on Windows
RichDom2185 cc44e75
Fix the command not running properly
leeyi45 0fb9836
Combine all the windows things into a single step
leeyi45 f2130a2
Maybe yarn was installed globally?
leeyi45 dc5f09d
Fix folder already exists
RichDom2185 02abd79
Does this work?
leeyi45 0870811
Make a windows version of the directory paths available
leeyi45 848be2d
Add a cwd check
leeyi45 c719288
Fix more TypeDoc
RichDom2185 1cd4346
Update docs about corepack
leeyi45 a20bd59
Update installation docs
leeyi45 643c342
Continue to try fixing the workflow
leeyi45 72e6c0e
Check working directory
leeyi45 8b06cf8
I have no idea why one evaluates to true and the other evalutes to false
leeyi45 fa85736
Check cwd
leeyi45 3841105
Remove all the windows directory stuff and just use yarn workspaces i…
leeyi45 f378383
Update test configs
leeyi45 cdf70e0
Try adding a new matcher for resolving paths
leeyi45 2bcf0dc
Update the buildtools tests for windows compatibility
leeyi45 a9f2d80
Add a "same path" comparer
leeyi45 e583162
Continue fixing tests to make them work on windows
leeyi45 f6847ad
Still fixing tests....
leeyi45 f11b4c4
Add some logging
leeyi45 773cd4c
Try and fix the markdown tree tests
leeyi45 ac00019
Fix the tsc thing
leeyi45 a2b03d9
Re-enable the full workflow
leeyi45 a08edba
Continue to try fix the doc server not building
leeyi45 21a0d30
Still trying to figure the docserver out
leeyi45 985d58a
Echo the changes value for docserver
leeyi45 388f14f
Use fromJSON
leeyi45 759a012
Returning a mapping doesn't work
leeyi45 90229db
Disable everything except for docserver
leeyi45 84a3c8f
Try using fromJSON in a different place
leeyi45 e1593c7
As a whole workflow, this should now work
leeyi45 6110d5c
Update deploy workflow
leeyi45 7e27aef
Update docs
leeyi45 e316080
Add the memory space option to lint:all
leeyi45 7117b7c
Remove unnecessary patch
leeyi45 ede60f0
Update lib/repotools/src/manifest.ts
RichDom2185 315a49e
Revert "Remove unnecessary patch"
RichDom2185 3e5b9b2
Reformat some Markdown files for readability
RichDom2185 d2ed1a5
Reformat more Markdown files
RichDom2185 0c8edb2
Reformat even more Markdown files
RichDom2185 b8b5ab2
Reformat remaining Markdown files
RichDom2185 25fe416
Update doc server and remove yarnhook
leeyi45 c0a6137
Add http server command to buildtools
leeyi45 e8b7ea1
Update libs and docs about focused installations
leeyi45 29e3198
Fix lint issue
leeyi45 dc62eba
Finally got linting code blocks in markdown files to work
leeyi45 16e46be
Fix dead links
leeyi45 c7e8765
Enable lint global to output stats too
leeyi45 e39dc33
Add a CSV formatter for ESLint statistics
leeyi45 1f1f9a4
Fix some docs
leeyi45 b30801a
Hide pathname from mqtt pic
leeyi45 b5e8328
Fix some flaws with the devserver
leeyi45 615f7b4
Update unittest bundle and tab to allow multiple and nested calls to …
leeyi45 4560af3
Reformat Markdown files
RichDom2185 5583e18
Fix AR bundle
RichDom2185 838ef37
Add a new action that rebuilds the tabs for the devserver if necessary
leeyi45 3833f37
Fix action always rebuilding artifact
leeyi45 b863da9
Will changing the order work?
leeyi45 0c50c75
Forgot to enable corepack
leeyi45 b518abd
Add manifest building
leeyi45 9c42e37
Cleanup
RichDom2185 c52eec3
Fix devserver workflow not working and modules-lib install taking for…
leeyi45 6a436b6
Add description to github actions package
leeyi45 11abc90
Time to figure out why playwright detection isn't working
leeyi45 a4e264a
Turns out I am just dumb and left playwright out of the curve tab's d…
leeyi45 ef48e95
Use headless install of playwright instead
leeyi45 78d3781
Miscellanous changes
leeyi45 51c5fb4
Update docs and lint configuration for quotes
leeyi45 1315c90
Fix the inconsistent semicolon delimiting in typescript types and int…
leeyi45 e61e287
Remove useless workspaces and modify templates to include all scripts
leeyi45 cd8845f
Test playwright caching
leeyi45 1d66fd2
Try another way to parse json
leeyi45 1960a43
Try installing the tab package
leeyi45 2e13ce2
Try focusing everything at once
leeyi45 4f04d86
Check if the playwright directory is found
leeyi45 2b96862
Fix error handling not working
leeyi45 df25d9b
Maybe this will work
leeyi45 9122f93
Try playwright tool caching
leeyi45 cc4a4ff
Use the workspace command instead
leeyi45 c937fa4
Fix using the wrong playwright option
leeyi45 086281d
Does adding the mkdirP call work?
leeyi45 a822167
Use cache instead of tool-cache
leeyi45 a638335
Remove tool-cache
leeyi45 b43125c
Restore everything else and stop using caching for playwright
leeyi45 138f19f
Add missing repotools tests
leeyi45 464d99c
Remove testing related tests since we can't really mock vite
leeyi45 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
20.11.1 | ||
22.16.0 |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"json.schemas": [ | ||
{ | ||
"fileMatch": ["src/bundles/**/manifest.json"], | ||
"url": "./lib/modules-lib/src/internal/manifest.schema.json" | ||
}, | ||
{ | ||
"fileMatch": ["./tsconfig.*.json"], | ||
"url": "http://json.schemastore.org/tsconfig" | ||
} | ||
] | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, possible to run some of these steps in parallel using multiple jobs/a matrix strategy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave this a brief go, but I'm most certainly not experienced enough with Github Actions to make this work. I've left some of my work in the repository and have just left the old workflow in place