Refactor/Cleanup Frontend (Part 2) #2724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we already explicitly type the containing object, redeclaring the function parameter types would only lead to worse code readability.
These styles seem to have been duplicated to `_achievementdashboard.scss` and not used anywhere.
Prevents unnecessary selector specificity. Since we now use CSS modules, there is no risk of style conflicts.
Also deleted some unused styles. Further refactoring awaits to properly separate out and group the relevant styles to relevant files.
Pull Request Test Coverage Report for Build 7649362514
💛 - Coveralls |
sayomaki
reviewed
Jan 25, 2024
sayomaki
approved these changes
Jan 25, 2024
CYX22222003
pushed a commit
to CYX22222003/frontendCYX
that referenced
this pull request
Feb 9, 2024
* Remove unnecessary type annotations Since we already explicitly type the containing object, redeclaring the function parameter types would only lead to worse code readability. * Remove unused styles These styles seem to have been duplicated to `_achievementdashboard.scss` and not used anywhere. * Move some academy styles to use CSS modules * Move AchievementCommentCard styles to CSS modules * Remove CSS selector nesting Prevents unnecessary selector specificity. Since we now use CSS modules, there is no risk of style conflicts. * Move Contributors to use CSS modules * Fix regressions due to `Academy` CSS module * Move some navigation bar styles to CSS modules * Fix format * Move GitHub assessment styles to CSS modules Also deleted some unused styles. Further refactoring awaits to properly separate out and group the relevant styles to relevant files. * Standardise CSS module filenames to use PascalCase * Update test snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By using CSS modules (supported out of the box), not only do we prevent global style name conflicts/clashes, but it is also easier to see which styles are referenced by which parts of the code.
This PR simply aims to move as much as possible to use CSS modules. Though it includes some reorganisation of stylesheets, this is not the main focus. As CSS modules will have an explicit import, it would be much easier to subsequently reorganise/simplify the stylesheets into different files once everything is migrated.
Also did a minor change to SICP by removing unnecessary type annotations for the paramters.
Type of change
How to test
There should not be any UI regressions.
Checklist