Bump Node.js to version 20, update documentation #2712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Install apt dependencies before building * Use checkout v3 instead of master * Replace manual caching strategy with updated setup node action
Pull Request Test Coverage Report for Build 7518563143
💛 - Coveralls |
RichDom2185
commented
Nov 13, 2023
sayomaki
reviewed
Nov 14, 2023
|
Tested and working with M1 Pro MBP Apple Silicon ( System Specifications:
Presumably it should work fine on x86_64 based macOS as well, given that there are no issues with M1-based systems. @RichDom2185 do you mind sharing more system information for those you have tested on? |
|
Also, I notice that |
|
* Create separate CONTRIBUTING.md file for developer-specific items * Reorganize and reword some sections and sentences
Include references to `.node-version` file and Python dependency, as well as simplifying some wording.
RichDom2185
changed the title
|
As far as I can tell there's no issues running on Windows |
chownces
reviewed
Jan 15, 2024
Comment on lines
+28
to
+31
| - name: yarn install and build | ||
| run: | | ||
| yarn install --frozen-lockfile | ||
| yarn run build |
There was a problem hiding this comment.
is there a reason for removing the build cache here?
looks good otherwise (M2 MBA Sonoma, Node 20.9.0, Python 3.9)
There was a problem hiding this comment.
Using
with:
cache: yarnin actions/setup-node handles this caching for us. We no longer need to manually set up caching of certain files/folders anymore.
chownces
approved these changes
Jan 15, 2024
CheongYeeMing
pushed a commit
to SA-Teams-Assessment/frontend
that referenced
this pull request
Jan 16, 2024
* Create .node-version file * Add selective WebGL dependency resolution * Bump node version in CI workflows * Fix missing dependencies in CI workflow * Update CD workflow * Install apt dependencies before building * Use checkout v3 instead of master * Replace manual caching strategy with updated setup node action * Fix typo in CLI option * Fix insufficient permissions * Update actions to v4 * Fix resolution warning * Reorganize documentation * Create separate CONTRIBUTING.md file for developer-specific items * Reorganize and reword some sections and sentences * Update and simplify README instructions Include references to `.node-version` file and Python dependency, as well as simplifying some wording. * Add Python 3.11 disclaimer
RichDom2185
added a commit
that referenced
this pull request
Mar 26, 2024
* Migrate ground control table to tanstack, without filtering and sorting functionalities * Add filter to ground control table * Remove defualt filter for ground control table * Add team size column for ground control table * Add ID to ground control table * Update team size edit cell * Add team size edit column for ground control * Remove console logs * Replace row-wise update button with one update button * Fix bug of team size edit cell not responding for the first click * Remove unused logs and dependencies * Fix dependency warning for ground control * Establish connection with Backend * Modify payload for postTeams API Call * Refetch after successfully creating Teams * Fix page button in team formation * Add config file * Modify response payload for fetching students * Refetch after successfully updating Teams * Add Upload CSV API Call * Update assessment workspace * Remove console logs * Add team information page to assessment workspace * Display names in team info page * Add team flag to assessment dashboard * Fix assessment overview card * Modify request to handle 409 Conflict Response * Update Upload Teams CSV format * Change minTeamSize to 0 * Add disable Save button in Assessment Workspace * Add TeamFormationOverview to SessionState * Revert changes made by Yiting * Add assessment type indication: Team or Individual * Add TeamFormationOverview to AssessmentWorkspce * Add role checks to remove error 403 * Modify GradingQuestion for team submissions * Remove console logs * Remove unused code * Resolve warning == * Add lastModifiedAt field for Answer * Add Save-Safe * Update Jest Snapshots * Write tests for FE components * Write test for SessionActions * Remove commented code * Add comments for API calls * Retrieve create team error message from BE resp * Add Workspace for TeamFormation * Update Team Formation Table Filter * Add Student Name Column Filter * Fix TeamFormation table global student name filter * Fix TeamFormation table global student name filter * Retrieve student username to grading * Resolve yarn lock * Split student names in grading editor * Fix Team Submission for GradingOverview * Fix Grading Table Header * Bump Node.js to version 20, update documentation (#2712) * Create .node-version file * Add selective WebGL dependency resolution * Bump node version in CI workflows * Fix missing dependencies in CI workflow * Update CD workflow * Install apt dependencies before building * Use checkout v3 instead of master * Replace manual caching strategy with updated setup node action * Fix typo in CLI option * Fix insufficient permissions * Update actions to v4 * Fix resolution warning * Reorganize documentation * Create separate CONTRIBUTING.md file for developer-specific items * Reorganize and reword some sections and sentences * Update and simplify README instructions Include references to `.node-version` file and Python dependency, as well as simplifying some wording. * Add Python 3.11 disclaimer * Prettier formatting rules * Yarn Eslint * Update snapshot * Fix yarn run tsc * Update snapshot * Update failing snapshots * Remove package-log.json Done as the project uses Yarn. * Restore old environment visualizer snapshots * Bump follow-redirects from 1.15.2 to 1.15.4 (#2720) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update field to generate new date * Remove commented code * Change student fields to array * Separate names in Team Formation Table by comma * Add Team related fields to GradingOverview * Fix yarn run tsc * Fix formatting issues * Remove commented code * Clean up some code * Remove console.log statement * Remove unused stylesheet import * Remove more commented code * Update Individual Assignment to have maxTeamSize of 1 * Remove commented code * Correct API response for GradingOverviews * Update failing snapshots * Remove unused code * Update snapshots post-merge conflict * Use CSS modules for team formation * Fix incorrect minimum team size * Clean up `GroundControlEditTeamSizeCell` * Update imports * Update typings * Remove commented code * Remove unused type export * Refactor to use `useCallback` * Remove unnecessary divs, classes * Remove unnecessary styles The styles won't matter for a flex item, thus are removed. * Remove unnecessary function * Simplify variable name for readability * Revert "Remove commented code" This reverts commit 0cf1f60. * Fix data flow for editing max team size * Fix unnecessary API calls * Reran yarn install post-merge * Remove unnecessary stub types package * Fix format post-merge * Update snapshots post-merge * Remove TODO comment The default value of 1 is intentional. * Make last modified date optional * Revert "Make last modified date optional" This reverts commit 6bebb24. * Update snapshots post-merge * Migrate new action creators to RTK * Fix incorrect past merge conflict resolution * Improve codebase consistency * Update lockfile * Update snapshots post-merge * Format files post-merge * Fix errors post-merge * Restore comment * Fix incorrect condition check * Update lockfile post merge * Migrate team actions to RTK * Fix tests * Fix compile error post-merge * Fix lint --------- Co-authored-by: Lu Yiting <[email protected]> Co-authored-by: Richard Dominick <[email protected]>
izruff
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Migrate ground control table to tanstack, without filtering and sorting functionalities * Add filter to ground control table * Remove defualt filter for ground control table * Add team size column for ground control table * Add ID to ground control table * Update team size edit cell * Add team size edit column for ground control * Remove console logs * Replace row-wise update button with one update button * Fix bug of team size edit cell not responding for the first click * Remove unused logs and dependencies * Fix dependency warning for ground control * Establish connection with Backend * Modify payload for postTeams API Call * Refetch after successfully creating Teams * Fix page button in team formation * Add config file * Modify response payload for fetching students * Refetch after successfully updating Teams * Add Upload CSV API Call * Update assessment workspace * Remove console logs * Add team information page to assessment workspace * Display names in team info page * Add team flag to assessment dashboard * Fix assessment overview card * Modify request to handle 409 Conflict Response * Update Upload Teams CSV format * Change minTeamSize to 0 * Add disable Save button in Assessment Workspace * Add TeamFormationOverview to SessionState * Revert changes made by Yiting * Add assessment type indication: Team or Individual * Add TeamFormationOverview to AssessmentWorkspce * Add role checks to remove error 403 * Modify GradingQuestion for team submissions * Remove console logs * Remove unused code * Resolve warning == * Add lastModifiedAt field for Answer * Add Save-Safe * Update Jest Snapshots * Write tests for FE components * Write test for SessionActions * Remove commented code * Add comments for API calls * Retrieve create team error message from BE resp * Add Workspace for TeamFormation * Update Team Formation Table Filter * Add Student Name Column Filter * Fix TeamFormation table global student name filter * Fix TeamFormation table global student name filter * Retrieve student username to grading * Resolve yarn lock * Split student names in grading editor * Fix Team Submission for GradingOverview * Fix Grading Table Header * Bump Node.js to version 20, update documentation (#2712) * Create .node-version file * Add selective WebGL dependency resolution * Bump node version in CI workflows * Fix missing dependencies in CI workflow * Update CD workflow * Install apt dependencies before building * Use checkout v3 instead of master * Replace manual caching strategy with updated setup node action * Fix typo in CLI option * Fix insufficient permissions * Update actions to v4 * Fix resolution warning * Reorganize documentation * Create separate CONTRIBUTING.md file for developer-specific items * Reorganize and reword some sections and sentences * Update and simplify README instructions Include references to `.node-version` file and Python dependency, as well as simplifying some wording. * Add Python 3.11 disclaimer * Prettier formatting rules * Yarn Eslint * Update snapshot * Fix yarn run tsc * Update snapshot * Update failing snapshots * Remove package-log.json Done as the project uses Yarn. * Restore old environment visualizer snapshots * Bump follow-redirects from 1.15.2 to 1.15.4 (#2720) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update field to generate new date * Remove commented code * Change student fields to array * Separate names in Team Formation Table by comma * Add Team related fields to GradingOverview * Fix yarn run tsc * Fix formatting issues * Remove commented code * Clean up some code * Remove console.log statement * Remove unused stylesheet import * Remove more commented code * Update Individual Assignment to have maxTeamSize of 1 * Remove commented code * Correct API response for GradingOverviews * Update failing snapshots * Remove unused code * Update snapshots post-merge conflict * Use CSS modules for team formation * Fix incorrect minimum team size * Clean up `GroundControlEditTeamSizeCell` * Update imports * Update typings * Remove commented code * Remove unused type export * Refactor to use `useCallback` * Remove unnecessary divs, classes * Remove unnecessary styles The styles won't matter for a flex item, thus are removed. * Remove unnecessary function * Simplify variable name for readability * Revert "Remove commented code" This reverts commit 0cf1f60. * Fix data flow for editing max team size * Fix unnecessary API calls * Reran yarn install post-merge * Remove unnecessary stub types package * Fix format post-merge * Update snapshots post-merge * Remove TODO comment The default value of 1 is intentional. * Make last modified date optional * Revert "Make last modified date optional" This reverts commit 6bebb24. * Update snapshots post-merge * Migrate new action creators to RTK * Fix incorrect past merge conflict resolution * Improve codebase consistency * Update lockfile * Update snapshots post-merge * Format files post-merge * Fix errors post-merge * Restore comment * Fix incorrect condition check * Update lockfile post merge * Migrate team actions to RTK * Fix tests * Fix compile error post-merge * Fix lint --------- Co-authored-by: Lu Yiting <[email protected]> Co-authored-by: Richard Dominick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Node 16 is EOL, and while upgrading to Node 18 seems to break GitHub runners and other x86 machines, surprisingly, bumping to Node 20 fixes these issues, although now they break on Apple Silicon.
But this is expected, since the version of
gldoes not technically support Node 18. Hence, I've manually bumped the version using selective dependency resolution. This is safe because if we take a look at their changelog, we see that the only reason for the major version bump from v5 to v6 is that they remove support for Node 12, with no other breaking changes besides that.I guess it's good we never bothered with Node 18 after all, since Node 18 just stopped being actively maintained.
TODO:
Type of change
Checklist