-
Notifications
You must be signed in to change notification settings - Fork 172
Disable persistence methods in Folder mode #2403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 2, 2023
Pull Request Test Coverage Report for Build 4587530945
💛 - Coveralls |
zhaojj2209
approved these changes
Apr 2, 2023
RichDom2185
pushed a commit
to NUS-CS1101S/cadet-frontend
that referenced
this pull request
Jul 15, 2023
* Update GitHub persistence to work with any active editor tab * Update Google Drive persistence to work with any active editor tab * Update PersistenceSaga tests * Disable Google Drive persistence in Folder mode * Disable GitHub persistence in Folder mode * Disable Folder mode when a persistence method is active
Pull Request Test Coverage Report for Build 4587530945Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The persistence methods will have to be reworked to account for Folder mode in the future. For now, we disallow saving to GitHub & Google Drive when in Folder mode.
Also updated the code relating to persistence so that it can work with any active editor tab index (and not just 0).
Related to #2176.
Type of change
How to test
The Folder mode is not yet ready for production and is disabled programmatically. Enable Folder mode for testing by changing the condition to
false
:frontend/src/pages/playground/Playground.tsx
Lines 609 to 622 in b90a7a2
Check that the persistence methods cannot be used in Folder mode.