Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

@garious
Copy link
Contributor

@garious garious commented Jan 30, 2019

Problem

Copy pasta

Summary of Changes

  • Generalize Transaction constructors to accept any implementation of KeypairUtil
  • Implement KeypairUtil in VoteSignerProxy
  • Delete the copy pasta

Fixes #

Copy link
Member

@aeyakovenko aeyakovenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@garious garious force-pushed the vote-signer-keypair branch from 9a07f78 to 70e35f9 Compare January 30, 2019 00:51
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a0bed53). Click here to learn what that means.
The diff coverage is 55.8%.

@@           Coverage Diff            @@
##             master   #2594   +/-   ##
========================================
  Coverage          ?   77.8%           
========================================
  Files             ?     112           
  Lines             ?   18211           
  Branches          ?       0           
========================================
  Hits              ?   14172           
  Misses            ?    4039           
  Partials          ?       0

1 similar comment
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a0bed53). Click here to learn what that means.
The diff coverage is 55.8%.

@@           Coverage Diff            @@
##             master   #2594   +/-   ##
========================================
  Coverage          ?   77.8%           
========================================
  Files             ?     112           
  Lines             ?   18211           
  Branches          ?       0           
========================================
  Hits              ?   14172           
  Misses            ?    4039           
  Partials          ?       0

@garious garious merged commit 85e7046 into solana-labs:master Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants