fix: Proper support for nested animatedProps objects and correct cleanup
#8726
+433
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of animated props arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds correct type for the
animatedPropsprop that doesn't include any layout animation-related props, allows nested arrays with mixed CSS and animated props objects. It also fixes the issue whit props cleanup that didn't work before (seepackages/react-native-reanimated/src/createAnimatedComponent/AnimatedComponent.tsx- the array of animated props was not detached from the view).It also adds a few typetests and jest unit tests that ensure the new behavior is correct.