-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(Worklets): runOnRuntimeSync
#8224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+240
−53
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a1daa99
Implement runOnRuntimeSync function
skusnierz 88e28d9
add type tests
skusnierz e15fb9c
add runtime tests
skusnierz 4b1adb2
Add docs
skusnierz 61f294a
fix runtime tests path
skusnierz 3a80161
add missing import to docs
skusnierz 8ebbf2e
Adjust to review
skusnierz c5f563e
Sort imports
skusnierz 0893dd9
chore: merge main
tjzel 2c0cded
chore: final touches
tjzel 032cf2d
chore: fix TS tests
tjzel 6f7e1a2
chore: fix docs
tjzel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
...on-app/src/apps/reanimated/examples/RuntimeTests/tests/runtimes/runOnRuntimeSync.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| import { | ||
| createSynchronizable, | ||
| createWorkletRuntime, | ||
| runOnJS, | ||
| runOnRuntimeSync, | ||
| scheduleOnRuntime, | ||
| } from 'react-native-worklets'; | ||
| import { describe, expect, test, notify, waitForNotification } from '../../ReJest/RuntimeTestsApi'; | ||
| import { ComparisonMode } from '../../ReJest/types'; | ||
|
|
||
| const NOTIFICATION_NAME = 'NOTIFICATION_NAME'; | ||
|
|
||
| describe('runOnRuntimeSync', () => { | ||
| test('use runOnRuntimeSync to run a function on the Worker Runtime from RN Runtime', () => { | ||
| // Arrange | ||
| const workletRuntime = createWorkletRuntime({ name: 'test' }); | ||
|
|
||
| // Act | ||
| const result = runOnRuntimeSync(workletRuntime, () => { | ||
| 'worklet'; | ||
| return 100; | ||
| }); | ||
|
|
||
| // Assert | ||
| expect(result).toBe(100, ComparisonMode.NUMBER); | ||
| }); | ||
|
|
||
| test('keep the correct order of execution runOnRuntimeSync and scheduleOnRuntime', async () => { | ||
| // Arrange | ||
| const workletRuntime = createWorkletRuntime({ name: 'test' }); | ||
| const synchronizable = createSynchronizable(0); | ||
|
|
||
| const onJSCallback = () => { | ||
| notify(NOTIFICATION_NAME); | ||
| }; | ||
|
|
||
| // Act | ||
| scheduleOnRuntime(workletRuntime, () => { | ||
| 'worklet'; | ||
| // heavy computation | ||
| new Array(50_000_000).map((_v, i) => i ** 2); | ||
| synchronizable.setBlocking(100); | ||
| runOnJS(onJSCallback)(); | ||
skusnierz marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| }); | ||
skusnierz marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| const result = runOnRuntimeSync(workletRuntime, () => { | ||
| 'worklet'; | ||
| return 100; | ||
| }); | ||
|
|
||
| // Assert | ||
| expect(result).toBe(100, ComparisonMode.NUMBER); | ||
| await waitForNotification(NOTIFICATION_NAME); | ||
| expect(synchronizable.getBlocking()).toBe(100, ComparisonMode.NUMBER); | ||
| }); | ||
| }); | ||
81 changes: 81 additions & 0 deletions
81
packages/docs-worklets/docs/threading/runOnRuntimeSync.mdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| --- | ||
| sidebar_position: 13 | ||
| --- | ||
|
|
||
| # runOnRuntimeSync | ||
|
|
||
| `runOnRuntimeSync` lets you run a [workletized](/docs/fundamentals/glossary#to-workletize) function synchronously on a [Worker Runtime](/docs/fundamentals/glossary#worker-worklet-runtime---worker-runtime). | ||
|
|
||
| ## Reference | ||
|
|
||
| ```javascript | ||
| import { runOnRuntimeSync, createWorkletRuntime } from 'react-native-worklets'; | ||
|
|
||
| const workletRuntime = createWorkletRuntime({ name: 'background' }); | ||
|
|
||
| const result = runOnRuntimeSync(workletRuntime, () => { | ||
| 'worklet'; | ||
| return 2+2; | ||
| }); | ||
|
|
||
| console.log(result); // 4 | ||
| ``` | ||
|
|
||
|
|
||
| <details> | ||
| <summary>Type definitions</summary> | ||
|
|
||
| ```typescript | ||
| function runOnRuntimeSync<Args extends unknown[], ReturnValue>( | ||
| workletRuntime: WorkletRuntime, | ||
| worklet: (...args: Args) => ReturnValue, | ||
| ...args: Args | ||
| ): ReturnValue | ||
| ``` | ||
|
|
||
| </details> | ||
|
|
||
| ## Arguments | ||
|
|
||
| ### workletRuntime | ||
|
|
||
| The worklet runtime to run the worklet on. | ||
|
|
||
| ### worklet | ||
|
|
||
| A reference to a function you want to execute on the [Worklet Runtime](/docs/fundamentals/glossary#worklet-runtime). | ||
|
|
||
| ### args | ||
|
|
||
| Arguments to the function you want to execute on the [Worklet Runtime](/docs/fundamentals/glossary#worklet-runtime). | ||
|
|
||
| ## Remarks | ||
|
|
||
| - The worklet cannot be run on the Worker Runtime from [UI | ||
| Runtime](/docs/fundamentals/glossary#ui-runtime) or another [Worker | ||
| Runtime](/docs/fundamentals/glossary#worker-worklet-runtime---worker-runtime), unless the [Bundle Mode](/docs/experimental/bundleMode) is enabled. | ||
skusnierz marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ```javascript | ||
| import { createWorkletRuntime, runOnRuntimeSync } from 'react-native-worklets'; | ||
| const workletRuntime = createWorkletRuntime({ name: 'background' }); | ||
| runOnUI(() => { | ||
| runOnRuntimeSync(workletRuntime, (greeting: string) => { | ||
| console.log(`${greeting} from the background Worklet Runtime`); | ||
| }, 'Hello'); // This will throw an error outside of Bundle Mode 🚨 | ||
| }); | ||
| ``` | ||
|
|
||
| ```javascript | ||
| import { createWorkletRuntime, scheduleOnRuntime } from 'react-native-worklets'; | ||
| const workletRuntime = createWorkletRuntime({ name: 'background' }); | ||
| const anotherWorkletRuntime = createWorkletRuntime({ name: 'anotherBackground' }); | ||
| runOnRuntimeSync(anotherWorkletRuntime, () => { | ||
| runOnRuntimeSync(workletRuntime, (greeting: string) => { | ||
| console.log(`${greeting} from the background Worklet Runtime`); | ||
| }, 'Hello'); // This will throw an error outside of Bundle Mode 🚨 | ||
| }); | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
packages/react-native-worklets/__typetests__/runOnRuntimeSync.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* eslint-disable @typescript-eslint/no-unused-vars */ | ||
| import { createWorkletRuntime, runOnRuntimeSync, runOnUISync } from '..'; | ||
|
|
||
| function runOnRuntimeSyncTypeTests() { | ||
| const workletRuntime = createWorkletRuntime({ name: 'test' }); | ||
| // Correct usage - correct usage | ||
| runOnRuntimeSync( | ||
| workletRuntime, | ||
| (num: number): number => { | ||
| return num + 1; | ||
| }, | ||
| 0 | ||
| ); | ||
|
|
||
| // @ts-expect-error - expected no args, but arg is provided | ||
| runOnRuntimeSync(workletRuntime, (): void => {}, 0); | ||
|
|
||
| // Wrong args type | ||
| runOnRuntimeSync( | ||
| workletRuntime, | ||
| (num: number): number => { | ||
| return num + 1; | ||
| }, | ||
| // @ts-expect-error - wrong args type | ||
| 'tets' | ||
| ); | ||
|
|
||
| // Wrong return type | ||
| runOnRuntimeSync( | ||
| workletRuntime, | ||
| (num: number): string => { | ||
| // @ts-expect-error - wrong return type | ||
| return num + 1; | ||
| }, | ||
| 0 | ||
| ); | ||
|
|
||
| // @ts-expect-error - wrong return type | ||
| const result: string = runOnRuntimeSync( | ||
| workletRuntime, | ||
| (num: number): number => { | ||
| return num + 1; | ||
| }, | ||
| 0 | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.