Fix possible linking error on Android due to undefined symbols from libworklets.so #7781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
force-pushed
the
@tomekzaw/android-linking-error
branch
from
b9c26b8 to
4dac618
Compare
tjzel
approved these changes
Jul 14, 2025
Member
Author
|
Together with @lukmccall we noticed that this solution has one major drawback of actually building the native code for each Android architecture in both debug and release modes (8 combinations in total) the which can take several minutes and can be a bit cumbersome as developers expect Gradle sync to take as little time as possible (seconds), not to forget about React Native core team efforts on that matter. Closing in favor of #7866. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I managed to reproduce this linking error only once but I decided to submit this PR anyway.
Based on:
error: undefined symbol: worklets::extractWorkletRuntimeon Android Expensify/react-native-live-markdown#627Test plan