Skip to content

Make tracing optional #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2024
Merged

Make tracing optional #60

merged 3 commits into from
Apr 22, 2024

Conversation

james7132
Copy link
Contributor

This PR makes tracing an optional dependency by putting all of the uses of tracing behind a cfg block.

notgull
notgull requested changes Apr 21, 2024
View reviewed changes
@james7132 james7132 requested a review from notgull April 21, 2024 23:50
notgull
notgull approved these changes Apr 21, 2024
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(When merging PRs with many commits like this, make sure to squash merge.)

@james7132 james7132 merged commit 3936595 into smol-rs:master Apr 22, 2024
@notgull notgull mentioned this pull request Apr 27, 2024
Merged
@taiki-e taiki-e mentioned this pull request Mar 28, 2025
Open
@taiki-e taiki-e mentioned this pull request Jun 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james7132 @notgull