Simplify installation #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the installation process of the runtime images we release, for humans as well as editor plugins that want to automatically install/update the language server. First thing I did was change the name of the release artifact for windows x64 from `windows-x64` to `windows-x86_64`. They generally refer to the same thing, and both the linux and mac x64 artifacts use x86_64, so automated downloads don't have to special case windows. The next thing I did was make it so the zips we release of the runtime images have a flat directory structure. By default (and seemingly with no way to change it), the runtime plugin creates a zip where the first entry is the directory being zipped. For example: ``` > unzip smithy-language-server-darwin-aarch64.zip > ls smithy-language-server-darwin-aarch64.zip smithy-language-server-darwin-aarch64/ ``` This commit makes it: ``` > unzip smithy-language-server-darwin-aarch64.zip > ls smithy-language-server-darwin-aarch64.zip bin/ conf/ ... you get the idea ``` Since the plugin doesn't provide you with a way to do this, I had to use some gradle wizardry to essentially override the default `runtimeZip` task so the task dependency graph stayed the same. The comment in build.gradle.kts has more details on how it works, but it basically just makes a custom Zip task for each target.
joewyz
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the installation process of the runtime images we release, for humans as well as editor plugins that want to automatically install/update the language server.
First thing I did was change the name of the release artifact for windows x64 from
windows-x64towindows-x86_64. They generally refer to the same thing, and both the linux and mac x64 artifacts use x86_64, so automated downloads don't have to special case windows.The next thing I did was make it so the zips we release of the runtime images have a flat directory structure. By default (and seemingly with no way to change it), the runtime plugin creates a zip where the first entry is the directory being zipped. For example:
This commit makes it:
Since the plugin doesn't provide you with a way to do this, I had to use some gradle wizardry to essentially override the default
runtimeZiptask so the task dependency graph stayed the same.The comment in build.gradle.kts has more details on how it works, but it basically just makes a custom Zip task for each target.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.