Fix: Add PdokNl provider #438 #440
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added a provider for https://www.pdok.nl/pdok-locatieserver. I'm not sure about the naming conventions, but as it's only available for Dutch addresses, I named it PdokNl, just like GeoApiFr. But I'm open for suggestions! Some noteworthy things: * If the provider does not get any results, but does get spelling suggestions, it will search again using the first suggestion. * In the raw results, there is a `highlight` key that highlights the matched word in the label. I didn't use that as label because the Leaflet control doesn't support that. See fixture for details.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was resolved by creating a separate PR because the sender did not have write permission in their repository. FYI @smeijer
The error has been fixed and it has been added to the project. #438
Thanks @JaZo