Fix/Check priority ranking when there is an existing alert #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCollin
approved these changes
Apr 6, 2020
iCollin
reviewed
Apr 6, 2020
Collaborator
iCollin
left a comment
iCollin
left a comment
There was a problem hiding this comment.
In case non mandatory priority parameter is missing, I think we should set the app to minimum priority.
Co-Authored-By: Collin <[email protected]>
iCollin
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements/Fixes #290
This PR is ready for review.
Testing Plan
Reproduce steps in issue with test_suite app
Summary
onUIAlertCLA