modalService.openSimpleModal shall return a promise #212

maxfriedmann · 2025-01-31T14:41:18Z

Fixes #203

vercel · 2025-01-31T14:41:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
svelte-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 31, 2025 2:54pm

codecov · 2025-01-31T14:44:00Z

Codecov Report

Attention: Patch coverage is 0% with 81 lines in your changes missing coverage. Please review.

Project coverage is 32.30%. Comparing base (7a5c164) to head (efad857).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/lib/modules/modals/ModalContainer.svelte	0.00%	32 Missing ⚠️
src/lib/modules/modals/Modal.svelte	0.00%	17 Missing and 1 partial ⚠️
src/lib/modules/styles/index.ts	0.00%	16 Missing and 1 partial ⚠️
src/lib/modules/modals/modal.service.svelte.ts	0.00%	13 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   33.95%   32.30%   -1.66%     
==========================================
  Files          42       44       +2     
  Lines        1013     1065      +52     
  Branches       52       86      +34     
==========================================
  Hits          344      344              
- Misses        658      680      +22     
- Partials       11       41      +30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

codecov · 2025-01-31T14:44:17Z

Bundle Report

Changes will increase total bundle size by 2.79MB (30.94%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name	Size	Change
@smallstack/svelte-ui-__sveltekit_1iz07js.app-client-esm	363.15kB	363.15kB (100%) ⬆️⚠️
@smallstack/svelte-ui-__sveltekit_1iz07js.app-server-esm	335.28kB	335.28kB (100%) ⬆️⚠️
@smallstack/svelte-ui-__sveltekit_1wdkdsq.app-client-esm	363.15kB	363.15kB (100%) ⬆️⚠️
@smallstack/svelte-ui-__sveltekit_15cwi1i.app-client-esm	363.15kB	363.15kB (100%) ⬆️⚠️
@smallstack/svelte-ui-__sveltekit_15cwi1i.app-server-esm	335.28kB	335.28kB (100%) ⬆️⚠️
@smallstack/svelte-ui-__sveltekit_eqfhq1.app-client-esm	363.15kB	363.15kB (100%) ⬆️⚠️
@smallstack/svelte-ui-__sveltekit_eqfhq1.app-server-esm	335.28kB	335.28kB (100%) ⬆️⚠️
@smallstack/svelte-ui-__sveltekit_1wdkdsq.app-server-esm	335.28kB	335.28kB (100%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: @smallstack/svelte-ui-__sveltekit_1iz07js.app-client-esm

App Routes Affected:

App Route	Size Change	Total Size	Change (%)
/modules/chat/chat-window (New)	6.01kB	6.01kB	100% 🚀
/modules/navigation/tabbar/fullscreen-example (New)	695 bytes	695 bytes	100% 🚀
/actions/overlay (New)	2.06kB	2.06kB	100% 🚀
/modules/navigation/app-shell (New)	2.15kB	2.15kB	100% 🚀
/forms/input (New)	559 bytes	559 bytes	100% 🚀
/modules/navigation/active-link (New)	890 bytes	890 bytes	100% 🚀
/modules/navigation/tabbar (New)	2.04kB	2.04kB	100% 🚀
/modules/chat/message-thread (New)	34.68kB	34.68kB	100% 🚀
/forms/date-time-range-input (New)	1.57kB	1.57kB	100% 🚀
/ (New)	4.1kB	4.1kB	100% 🚀
/forms/signature-pad-input (New)	1.17kB	1.17kB	100% 🚀
/modules/modals/modal-service (New)	5.55kB	5.55kB	100% 🚀
/install (New)	3.68kB	3.68kB	100% 🚀
/actions/viewport (New)	1.67kB	1.67kB	100% 🚀

view changes for bundle: @smallstack/svelte-ui-__sveltekit_15cwi1i.app-server-esm

App Routes Affected:

App Route	Size Change	Total Size	Change (%)
/modules/chat/chat-window (New)	6.41kB	6.41kB	100% 🚀
/modules/navigation/tabbar/fullscreen-example (New)	878 bytes	878 bytes	100% 🚀
/actions/overlay (New)	2.65kB	2.65kB	100% 🚀
/modules/navigation/app-shell (New)	2.74kB	2.74kB	100% 🚀
/forms/input (New)	1.77kB	1.77kB	100% 🚀
/modules/navigation/active-link (New)	1.14kB	1.14kB	100% 🚀
/modules/navigation/tabbar (New)	3.1kB	3.1kB	100% 🚀
/modules/chat/message-thread (New)	6.76kB	6.76kB	100% 🚀
/robots.txt (New)	144 bytes	144 bytes	100% 🚀
/ (New)	20.72kB	20.72kB	100% 🚀
/forms/signature-pad-input (New)	3.65kB	3.65kB	100% 🚀
/modules/modals/modal-service (New)	5.57kB	5.57kB	100% 🚀
/forms/date-time-range-input (New)	5.33kB	5.33kB	100% 🚀
/actions/viewport (New)	1.93kB	1.93kB	100% 🚀
/install (New)	3.03kB	3.03kB	100% 🚀

view changes for bundle: @smallstack/svelte-ui-__sveltekit_eqfhq1.app-server-esm

App Routes Affected:

App Route	Size Change	Total Size	Change (%)
/modules/chat/chat-window (New)	6.41kB	6.41kB	100% 🚀
/modules/navigation/tabbar/fullscreen-example (New)	878 bytes	878 bytes	100% 🚀
/actions/overlay (New)	2.65kB	2.65kB	100% 🚀
/modules/navigation/app-shell (New)	2.74kB	2.74kB	100% 🚀
/forms/input (New)	1.77kB	1.77kB	100% 🚀
/modules/navigation/active-link (New)	1.14kB	1.14kB	100% 🚀
/modules/navigation/tabbar (New)	3.1kB	3.1kB	100% 🚀
/modules/chat/message-thread (New)	6.76kB	6.76kB	100% 🚀
/robots.txt (New)	144 bytes	144 bytes	100% 🚀
/ (New)	20.72kB	20.72kB	100% 🚀
/forms/signature-pad-input (New)	3.65kB	3.65kB	100% 🚀
/modules/modals/modal-service (New)	5.57kB	5.57kB	100% 🚀
/forms/date-time-range-input (New)	5.33kB	5.33kB	100% 🚀
/actions/viewport (New)	1.93kB	1.93kB	100% 🚀
/install (New)	3.03kB	3.03kB	100% 🚀

view changes for bundle: @smallstack/svelte-ui-__sveltekit_1wdkdsq.app-server-esm

App Routes Affected:

App Route	Size Change	Total Size	Change (%)
/modules/chat/chat-window (New)	6.41kB	6.41kB	100% 🚀
/modules/navigation/tabbar/fullscreen-example (New)	878 bytes	878 bytes	100% 🚀
/actions/overlay (New)	2.65kB	2.65kB	100% 🚀
/modules/navigation/app-shell (New)	2.74kB	2.74kB	100% 🚀
/forms/input (New)	1.77kB	1.77kB	100% 🚀
/modules/navigation/active-link (New)	1.14kB	1.14kB	100% 🚀
/modules/navigation/tabbar (New)	3.1kB	3.1kB	100% 🚀
/modules/chat/message-thread (New)	6.76kB	6.76kB	100% 🚀
/robots.txt (New)	144 bytes	144 bytes	100% 🚀
/ (New)	20.72kB	20.72kB	100% 🚀
/forms/signature-pad-input (New)	3.65kB	3.65kB	100% 🚀
/modules/modals/modal-service (New)	5.57kB	5.57kB	100% 🚀
/forms/date-time-range-input (New)	5.33kB	5.33kB	100% 🚀
/actions/viewport (New)	1.93kB	1.93kB	100% 🚀
/install (New)	3.03kB	3.03kB	100% 🚀

view changes for bundle: @smallstack/svelte-ui-__sveltekit_1iz07js.app-server-esm

App Routes Affected:

App Route	Size Change	Total Size	Change (%)
/modules/chat/chat-window (New)	6.41kB	6.41kB	100% 🚀
/modules/navigation/tabbar/fullscreen-example (New)	878 bytes	878 bytes	100% 🚀
/actions/overlay (New)	2.65kB	2.65kB	100% 🚀
/modules/navigation/app-shell (New)	2.74kB	2.74kB	100% 🚀
/forms/input (New)	1.77kB	1.77kB	100% 🚀
/modules/navigation/active-link (New)	1.14kB	1.14kB	100% 🚀
/modules/navigation/tabbar (New)	3.1kB	3.1kB	100% 🚀
/modules/chat/message-thread (New)	6.76kB	6.76kB	100% 🚀
/robots.txt (New)	144 bytes	144 bytes	100% 🚀
/ (New)	20.72kB	20.72kB	100% 🚀
/forms/signature-pad-input (New)	3.65kB	3.65kB	100% 🚀
/modules/modals/modal-service (New)	5.57kB	5.57kB	100% 🚀
/forms/date-time-range-input (New)	5.33kB	5.33kB	100% 🚀
/actions/viewport (New)	1.93kB	1.93kB	100% 🚀
/install (New)	3.03kB	3.03kB	100% 🚀

view changes for bundle: @smallstack/svelte-ui-__sveltekit_15cwi1i.app-client-esm

App Routes Affected:

App Route	Size Change	Total Size	Change (%)
/modules/chat/chat-window (New)	6.01kB	6.01kB	100% 🚀
/modules/navigation/tabbar/fullscreen-example (New)	695 bytes	695 bytes	100% 🚀
/actions/overlay (New)	2.06kB	2.06kB	100% 🚀
/modules/navigation/app-shell (New)	2.15kB	2.15kB	100% 🚀
/forms/input (New)	559 bytes	559 bytes	100% 🚀
/modules/navigation/active-link (New)	890 bytes	890 bytes	100% 🚀
/modules/navigation/tabbar (New)	2.04kB	2.04kB	100% 🚀
/modules/chat/message-thread (New)	5.42kB	5.42kB	100% 🚀
/forms/date-time-range-input (New)	1.57kB	1.57kB	100% 🚀
/ (New)	4.1kB	4.1kB	100% 🚀
/forms/signature-pad-input (New)	1.17kB	1.17kB	100% 🚀
/modules/modals/modal-service (New)	5.55kB	5.55kB	100% 🚀
/install (New)	3.68kB	3.68kB	100% 🚀
/actions/viewport (New)	1.67kB	1.67kB	100% 🚀

view changes for bundle: @smallstack/svelte-ui-__sveltekit_1wdkdsq.app-client-esm

App Routes Affected:

App Route	Size Change	Total Size	Change (%)
/modules/chat/chat-window (New)	6.01kB	6.01kB	100% 🚀
/modules/navigation/tabbar/fullscreen-example (New)	695 bytes	695 bytes	100% 🚀
/actions/overlay (New)	2.06kB	2.06kB	100% 🚀
/modules/navigation/app-shell (New)	2.15kB	2.15kB	100% 🚀
/forms/input (New)	559 bytes	559 bytes	100% 🚀
/modules/navigation/active-link (New)	890 bytes	890 bytes	100% 🚀
/modules/navigation/tabbar (New)	2.04kB	2.04kB	100% 🚀
/modules/chat/message-thread (New)	5.42kB	5.42kB	100% 🚀
/forms/date-time-range-input (New)	1.57kB	1.57kB	100% 🚀
/ (New)	4.1kB	4.1kB	100% 🚀
/forms/signature-pad-input (New)	1.17kB	1.17kB	100% 🚀
/modules/modals/modal-service (New)	5.55kB	5.55kB	100% 🚀
/install (New)	3.68kB	3.68kB	100% 🚀
/actions/viewport (New)	1.67kB	1.67kB	100% 🚀

view changes for bundle: @smallstack/svelte-ui-__sveltekit_eqfhq1.app-client-esm

App Routes Affected:

App Route	Size Change	Total Size	Change (%)
/modules/chat/chat-window (New)	6.01kB	6.01kB	100% 🚀
/modules/navigation/tabbar/fullscreen-example (New)	695 bytes	695 bytes	100% 🚀
/actions/overlay (New)	2.06kB	2.06kB	100% 🚀
/modules/navigation/app-shell (New)	2.15kB	2.15kB	100% 🚀
/forms/input (New)	559 bytes	559 bytes	100% 🚀
/modules/navigation/active-link (New)	890 bytes	890 bytes	100% 🚀
/modules/navigation/tabbar (New)	2.04kB	2.04kB	100% 🚀
/modules/chat/message-thread (New)	5.42kB	5.42kB	100% 🚀
/forms/date-time-range-input (New)	1.57kB	1.57kB	100% 🚀
/ (New)	4.1kB	4.1kB	100% 🚀
/forms/signature-pad-input (New)	1.17kB	1.17kB	100% 🚀
/modules/modals/modal-service (New)	5.55kB	5.55kB	100% 🚀
/install (New)	3.68kB	3.68kB	100% 🚀
/actions/viewport (New)	1.67kB	1.67kB	100% 🚀

maxfriedmann added 5 commits January 31, 2025 08:04

Export styles as module entry

e277d25

0.5.0-beta.0

f54e188

Fix dialog class names

06b5bfd

0.5.0-beta.1

17955ed

modalService.openSimpleModal shall return a promise

7db2b09

Fixes #203

maxfriedmann enabled auto-merge January 31, 2025 14:41

vercel bot deployed to Preview January 31, 2025 14:42 View deployment

Add cursor pointer to signature pad input snapshots

efad857

vercel bot deployed to Preview January 31, 2025 14:54 View deployment

maxfriedmann disabled auto-merge January 31, 2025 14:57

maxfriedmann merged commit fec7066 into main Jan 31, 2025
9 of 11 checks passed

maxfriedmann deleted the maxfriedmann/issue203 branch January 31, 2025 14:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

modalService.openSimpleModal shall return a promise #212

modalService.openSimpleModal shall return a promise #212

Uh oh!

maxfriedmann commented Jan 31, 2025

Uh oh!

vercel bot commented Jan 31, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jan 31, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jan 31, 2025 •

edited

Loading

App Routes Affected:

App Routes Affected:

App Routes Affected:

App Routes Affected:

App Routes Affected:

App Routes Affected:

App Routes Affected:

App Routes Affected:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

modalService.openSimpleModal shall return a promise #212

modalService.openSimpleModal shall return a promise #212

Uh oh!

Conversation

maxfriedmann commented Jan 31, 2025

Uh oh!

vercel bot commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov bot commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

App Routes Affected:

App Routes Affected:

App Routes Affected:

App Routes Affected:

App Routes Affected:

App Routes Affected:

App Routes Affected:

App Routes Affected:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Jan 31, 2025 •

edited

Loading

codecov bot commented Jan 31, 2025 •

edited

Loading

codecov bot commented Jan 31, 2025 •

edited

Loading