Sort numbers in unions while validating twoslash (//=>) types in codeblocks
#1320
+135
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-sm
force-pushed
the
feat/normalize-union-types
branch
from
f023289 to
33441ca
Compare
som-sm
force-pushed
the
feat/normalize-union-types
branch
from
33441ca to
50c1438
Compare
som-sm
commented
Dec 23, 2025
Collaborator
Author
There was a problem hiding this comment.
The conversion of double quotes to single quotes and spaces to tabs now happens as part of union sorting, not during quickinfo type extraction, since formatting changes made earlier would otherwise be overwritten by the sorting step.
Collaborator
Author
|
@sindresorhus I've created an intermediate PR so that it's easy to review and refer back to these changes. |
sindresorhus
merged commit 6bbfa9e
into
feat/validate-twoslash-type-hints-in-codeblocks
1 check passed
som-sm
added a commit
that referenced
this pull request
Dec 25, 2025
som-sm
added a commit
that referenced
this pull request
Dec 25, 2025
som-sm
added a commit
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an intermediate PR on #1309 that addresses #1309 (comment).