GreaterThanOrEqual / LessThan: Fix behaviour with operands like N and N | N + >0
#1280
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GreaterThanOrEqualcurrently doesn’t distributeAandBbefore checking whetherA extends B.type-fest/source/greater-than-or-equal.d.ts
Lines 20 to 22 in 5612f64
As a result, if
Ais1andBis1 | 2, the conditionA extends Bsatisfies, causing the type to returntrueand completely ignore the| 2part inB.This PR fixes the behavior by distributing
AandBbefore performing the check.Similar issue happens with
LessThanbecause it's dependent onGreaterThanOrEqual.