UnionToIntersection: Fix incorrect test case
#1260
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
& Unionbit inUnionToIntersectionwas added in #682, but the test case added along with it was incorrect.type-fest/source/union-to-intersection.d.ts
Line 60 in 3bd9de6
The test actually does nothing, as already pointed out in #682 (comment).
type-fest/test-d/union-to-intersection.ts
Lines 11 to 14 in 3bd9de6
This PR adds a generic assignability test that correctly verifies the
& Unionchange as it only passes when the change is present. The updated test case basically verifies thatUnionToIntersection<T | U | ...>is assignable toT | U | ....Thanks to @Beraliv for pointing this out in ts-essentials/ts-essentials#451 (comment).