Skip to content

Additons to Sign with rekorv2 #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 10, 2025
Merged

Additons to Sign with rekorv2 #1437

merged 6 commits into from
Jun 10, 2025

Conversation

ramonpetgrave64
Copy link
Contributor

Additons to PR #1432

  • refactoring the bundle entry body validation into separate functions
  • add a sample dsse bundle produced with rekorv2 and a test to verify that bundle

Summary

Release Note

Documentation

@ramonpetgrave64 ramonpetgrave64 marked this pull request as draft June 9, 2025 21:52
@ramonpetgrave64
use ambient oidc
29f14bd 
Signed-off-by: Ramon Petgrave <[email protected]>
@ramonpetgrave64 ramonpetgrave64 marked this pull request as ready for review June 9, 2025 22:15
jku
jku approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks

@jku
Copy link
Member

jku commented Jun 10, 2025

I'll merge this manually so we keep the commits while the main PR is in review

@jku jku merged commit 29f14bd into sigstore:sign-with-rekorv2 Jun 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jku jku jku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramonpetgrave64 @jku