Skip to content

Add verification errors to output of VerifyTimestampAuthority #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

codysoyland
Copy link
Member

Summary

This is an alternative to #325 which modifies the return value of VerifyTimestampAuthority to include verification errors separately from non-verification errors.

Release Note

Documentation

@codysoyland codysoyland requested a review from a team as a code owner May 8, 2025 13:49
@codysoyland codysoyland force-pushed the tsa-verification-errors-v2 branch from d834616 to 1c30f49 Compare May 8, 2025 14:10
Copy link
Member

@steiza steiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! It'll definitely help us surface non-critical failures to users so they can do debugging or better understand what is going on, like for #48.

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on two approaches. I like this one more, since it fits well into how we are currently verifying bundles. We can also update Rekor to do the same.

@codysoyland codysoyland merged commit 94bb81b into main May 8, 2025
12 checks passed
@codysoyland codysoyland deleted the tsa-verification-errors-v2 branch May 8, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants