Bump TSA library to relax EKU chain validation rules #4219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sigstore#3632 Signed-off-by: Hayden B <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4219 +/- ##
==========================================
- Coverage 40.10% 34.41% -5.70%
==========================================
Files 155 210 +55
Lines 10044 13746 +3702
==========================================
+ Hits 4028 4730 +702
- Misses 5530 8429 +2899
- Partials 486 587 +101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cpanato
approved these changes
Jun 3, 2025
steiza
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3632
We had strict EKU chain validation in the TSA library, requiring every intermediate in the chain to include the timestamping ExtendedKeyUsage bit. This caused issues for verification with Digicert's chain, so we've relaxed the validation rules.
Release Note
Documentation