Make e2e service health check more flexible #4216
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 62a6617 in rekor, health checks were added to the trillian services, which means now five of the five services will report "healthy" when running. The cosign e2e tests were checking that exactly 3 were healthy, so if they started too fast and 4 or more were healthy, the tests would fail. This change makes the check more flexible. It is not very sophisticated, as it's technically possible the wrong 3 services are healthy, but it should still be good enough to serve its purpose in CI. Signed-off-by: Colleen Murphy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4216 +/- ##
==========================================
- Coverage 40.10% 34.41% -5.69%
==========================================
Files 155 210 +55
Lines 10044 13747 +3703
==========================================
+ Hits 4028 4731 +703
- Misses 5530 8429 +2899
- Partials 486 587 +101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I added a fix for this in https://github.com/sigstore/cosign/pull/4213/files#diff-c51c51ea1233078ae52e43453d38ef2751183093452770a9b74bc88828541aed, WDYT about this approach? |
|
Works for me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 62a6617 in rekor, health checks were added to the trillian services, which means now five of the five services will report "healthy" when running. The cosign e2e tests were checking that exactly 3 were healthy, so if they started too fast and 4 or more were healthy, the tests would fail. This change makes the check more flexible. It is not very sophisticated, as it's technically possible the wrong 3 services are healthy, but it should still be good enough to serve its purpose in CI.
Summary
Release Note
Documentation