Skip to content

Feat/non filename completions #4115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

scop
Copy link
Contributor

@scop scop commented Mar 14, 2025

Summary

As described in sigstore/community#569

To test, generate and install shell completions and invoke completion for flags not taking filenames as arguments that are addressed in this PR, observe results.

Release Note

NONE

Documentation

NONE

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 36.41%. Comparing base (2ef6022) to head (eea9cf2).
Report is 355 commits behind head on main.

Files with missing lines Patch % Lines
cmd/cosign/cli/options/attach.go 0.00% 7 Missing ⚠️
cmd/cosign/cli/options/bundle.go 0.00% 6 Missing ⚠️
cmd/cosign/cli/options/attest_blob.go 0.00% 5 Missing ⚠️
cmd/cosign/cli/options/attest.go 0.00% 4 Missing ⚠️
cmd/cosign/cli/options/signblob.go 0.00% 2 Missing ⚠️
cmd/cosign/cli/options/annotations.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4115      +/-   ##
==========================================
- Coverage   40.10%   36.41%   -3.69%     
==========================================
  Files         155      210      +55     
  Lines       10044    13751    +3707     
==========================================
+ Hits         4028     5008     +980     
- Misses       5530     8115    +2585     
- Partials      486      628     +142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bobcallaway
Copy link
Member

can you please run make docgen, and then add the Signed-Off-By via git commit -s to meet our DCO requirements

@scop scop force-pushed the feat/non-filename-completions branch from 5f5782d to ffeb8e1 Compare March 25, 2025 18:57
@scop scop force-pushed the feat/non-filename-completions branch from ffeb8e1 to eea9cf2 Compare March 25, 2025 18:57
@scop
Copy link
Contributor Author

scop commented Mar 25, 2025

Done.

@bobcallaway bobcallaway enabled auto-merge (squash) March 25, 2025 19:22
@bobcallaway bobcallaway merged commit 37bae90 into sigstore:main Mar 25, 2025
29 checks passed
@scop scop deleted the feat/non-filename-completions branch March 25, 2025 19:53
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request May 10, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cosign](https://github.com/sigstore/cosign) | minor | `2.4.3` -> `2.5.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>sigstore/cosign (cosign)</summary>

### [`v2.5.0`](https://github.com/sigstore/cosign/blob/HEAD/CHANGELOG.md#v250)

[Compare Source](sigstore/cosign@v2.4.3...v2.5.0)

v2.5.0 includes an implementation of the new bundle specification,
attesting and verifying OCI image attestations uploaded as OCI artifacts.
This feature is currently gated behind the `--new-bundle-format` flag
when running `cosign attest`.

#### Features

-   Add support for new bundle specification for attesting/verifying OCI image attestations ([#&#8203;3889](sigstore/cosign#3889))
-   Feat/non filename completions ([#&#8203;4115](sigstore/cosign#4115))
-   Add TSA certificate related flags and fields for cosign attest ([#&#8203;4079](sigstore/cosign#4079))

#### Fixes

-   cmd/cosign/cli: fix typo in ignoreTLogMessage ([#&#8203;4111](sigstore/cosign#4111))
-   Fix replace with compliant image mediatype ([#&#8203;4077](sigstore/cosign#4077))

#### Contributors

-   Bob Callaway
-   Carlos Tadeu Panato Junior
-   Cody Soyland
-   Dmitry Savintsev
-   Hayden B
-   Ramon Petgrave
-   Riccardo Schirone
-   Stef Graces
-   Ville Skyttä

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yNTkuMCIsInVwZGF0ZWRJblZlciI6IjM5LjI1OS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants