Don't ignore transparency log in tests if possible #3528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the e2e tests to default to setting IgnoreTlog to false where possible. In some cases, where the IgnoreTlog functionality is being explicitly tested, continue to set it to true. Since the transparency log isn't being ignored, the signing commands need to upload it and need the rekor public key and URL in order to do so. Removes one redundant test. Signed-off-by: Colleen Murphy <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3528 +/- ##
==========================================
+ Coverage 40.10% 40.44% +0.34%
==========================================
Files 155 155
Lines 10044 10047 +3
==========================================
+ Hits 4028 4064 +36
+ Misses 5530 5494 -36
- Partials 486 489 +3 ☔ View full report in Codecov by Sentry. |
haydentherapper
approved these changes
Feb 9, 2024
Contributor
haydentherapper
left a comment
haydentherapper
left a comment
There was a problem hiding this comment.
Thanks! Very happy to have end to end test coverage for this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the e2e tests to default to setting IgnoreTlog to false where possible. In some cases, where the IgnoreTlog functionality is being explicitly tested, continue to set it to true.
Since the transparency log isn't being ignored, the signing commands need to upload it and need the rekor public key and URL in order to do so.
Removes one redundant test.
Followup to #3499 (comment)
Summary
Release Note
Documentation