Skip to content

fix(sofia.conf.xml): replace deprecated rtp-hold-timeout-sec #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

seuros
Copy link

@seuros seuros commented Jan 6, 2025

I think the default configuration should not be using deprecated param

@seuros seuros force-pushed the master branch 2 times, most recently from c761d39 to 8116d68 Compare January 10, 2025 22:29
@seven1240
Copy link
Collaborator

LGTM, but can you also all places in conf/ dir ?

@seuros seuros force-pushed the master branch 3 times, most recently from dc8d3a1 to a19e445 Compare May 24, 2025 02:23
@seuros
Copy link
Author

seuros commented May 24, 2025

@seven1240 Done, i replaced it in every examples, i also updated the tests.

@ticpu
Copy link

ticpu commented Jul 1, 2025

Did you test that out?

media_timeout is not in seconds and I'm not even sure it can be set at this place. Can you confirm the timeout really apply from that point and that calls can complete in high latency environment (>300ms) ?

@ticpu
Copy link

ticpu commented Jul 2, 2025

@seuros I see you updated the pull request but the same issue persist. media_timeout isn't a mod_sofia parameter anymore. It is part of the media core and shouldn't be exposed as an example sofia param.

Furthermore, it is now in milliseconds so 300 means 0.3 second.

Either remove it from the sample configurations or add it somewhere in the dialplan instead.

@seuros
Copy link
Author

seuros commented Jul 2, 2025

@ticpu Thank you for input, i did test that branch , and your concern is valid, the timeout changed from 300s to .3 s.

I never noticed the bug because my usage for FS is automated, and never trigger it.

I rebased in the morning via the GUI to remember to handle this issue.

I'm pushing the correction in few moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants