Skip to content

fix: null-prototype objects missing toString method #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2025
Merged

fix: null-prototype objects missing toString method #1042

merged 2 commits into from
Mar 18, 2025

Conversation

amertak
Copy link
Contributor

@amertak amertak commented Mar 14, 2025 •
edited
Loading

Description

Fixes toString being called on null-prototype objects

Issue 1041

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Delete options that are not relevant.

  • Manual testing
  • Integration test

@amertak amertak marked this pull request as ready for review March 18, 2025 09:56
@amertak amertak requested review from a team as code owners March 18, 2025 09:56
@amertak amertak requested review from potty and millcek March 18, 2025 09:56
@amertak amertak merged commit 1f3a47e into main Mar 18, 2025
10 checks passed
@amertak amertak deleted the fix/error-instrumentation branch March 18, 2025 12:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@potty potty potty approved these changes

@millcek millcek millcek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amertak @potty @millcek