-
Notifications
You must be signed in to change notification settings - Fork 26
DEMRUM-1663: Cleanup #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEMRUM-1663: Cleanup #307
Conversation
…se OTel Api and SDK directly instead of SplunkOpenTelemetry.
…directory from Public API directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Only a few minor tweaks would be beneficial.
...ry/Sources/SplunkOpenTelemetry/Attribute Checker Exporters/AttributeCheckerLogExporter.swift
Outdated
Show resolved
Hide resolved
...y/Sources/SplunkOpenTelemetry/Attribute Checker Exporters/AttributeCheckerSpanExporter.swift
Outdated
Show resolved
Hide resolved
SplunkAgent/Tests/SplunkAgentTests/Public API/Model/MutableAttributesTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
This PR removes some unneeded functionality from the old agent. Also tries to apply linter to all modules, and fixes couple hundred linter issues.
Changes made:
.swiftpm
and.gitignore
filessession.id
parametersPackage.swift
dependency graph by using OpenTelemetry dependencies directly instead of usingSplunkOpenTelemetry