Skip to content

DEMRUM-773 Network Info Module #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: feature/next-gen
Choose a base branch
from
Open

DEMRUM-773 Network Info Module #304

wants to merge 17 commits into from

Conversation

SMickelsn
Copy link
Contributor

@SMickelsn SMickelsn commented May 20, 2025 •
edited
Loading

  • Module to detect Network Info
  • Sends initial network state and then monitors and sends updated state when changes are detected.

@SMickelsn SMickelsn requested review from a team as code owners May 20, 2025 19:28
@SMickelsn SMickelsn marked this pull request as draft May 20, 2025 19:28
@SMickelsn SMickelsn marked this pull request as ready for review June 3, 2025 01:39
@SMickelsn SMickelsn changed the title DEMRUM-773 Initial Network Info method DEMRUM-773 Network Info Module Jun 3, 2025
carlosmcevilly
carlosmcevilly approved these changes Jun 3, 2025
View reviewed changes
Copy link

@carlosmcevilly carlosmcevilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There was one nit but we can catch that one next time if you want to merge this as is.

@aditi-s3 aditi-s3 requested a review from jCharv June 3, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosmcevilly carlosmcevilly carlosmcevilly approved these changes

@jCharv jCharv Awaiting requested review from jCharv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SMickelsn @carlosmcevilly