Dvernon: MOB-3260/MOB-3261 - New Options #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemk
approved these changes
Aug 2, 2023
| @@ -156,6 +166,11 @@ public let DEFAULT_DISK_CACHE_MAX_SIZE_BYTES: Int64 = 25 * 1024 * 1024 | |||
| */ | |||
| @objc public var sessionSamplingRatio: Double = 1.0 | |||
|
|
|||
| /** | |||
| Set the time interval between batch span sampling in seconds | |||
There was a problem hiding this comment.
Perhaps a more apt description would be "maximum interval between 2 consecutive span exports"
| /** | ||
| Set the time interval between batch span sampling in seconds | ||
| */ | ||
| @objc public var spanSchedulingDelay: TimeInterval = 5.0 |
There was a problem hiding this comment.
A few alternative naming ideas: bspScheduleDelay, batchSpanProcessorScheduleDelay to hint that it's related to OTel's batch span processor? For example in the OTel spec the environment variable corresponding to this option is named OTEL_BSP_SCHEDULE_DELAY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates new options for:
@theletterf the slowRenderingDetectionEnabled is already mentioned in the docs, but it claims that the default value is false. The default value should be changed to true, as that was the previous default behavior (the customer didn't have a way to turn it off) and it's Android's default behavior as well.