Skip to content

MySQL driver instrumentation #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Sep 23, 2021
Merged

MySQL driver instrumentation #90

merged 21 commits into from
Sep 23, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 9, 2021

Add instrumentation for the mysql package.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2021

Codecov Report

Merging #90 (cc1f970) into main (9bc2eb1) will increase coverage by 0.73%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   87.28%   88.02%   +0.73%     
==========================================
  Files          17       18       +1     
  Lines         535      568      +33     
==========================================
+ Hits          467      500      +33     
  Misses         49       49              
  Partials       19       19              
Flag Coverage Δ
Linux 88.02% <100.00%> (+0.73%) ⬆️
Windows 88.02% <100.00%> (+0.73%) ⬆️
macOS 88.02% <100.00%> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../github.com/go-sql-driver/mysql/splunkmysql/sql.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc2eb1...cc1f970. Read the comment docs.

@MrAlias MrAlias changed the title MySQL driver instrumentation PoC MySQL driver instrumentation Sep 21, 2021
@MrAlias MrAlias marked this pull request as ready for review September 21, 2021 16:23
@MrAlias MrAlias requested review from a team as code owners September 21, 2021 16:23
Copy link
Contributor

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure it is tested E2E before merging 😉

Can you also create an issue to add integration tests after merging?

@pellared
Copy link
Contributor

I see some build issues, but other than that LGTM 👍

@MrAlias MrAlias merged commit 8ce4383 into signalfx:main Sep 23, 2021
@MrAlias MrAlias deleted the splunkmysql branch September 23, 2021 21:55
@MrAlias MrAlias mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants