-
Notifications
You must be signed in to change notification settings - Fork 21
MySQL driver instrumentation #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4aade2d
to
c724ca2
Compare
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 87.28% 88.02% +0.73%
==========================================
Files 17 18 +1
Lines 535 568 +33
==========================================
+ Hits 467 500 +33
Misses 49 49
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure it is tested E2E before merging 😉
Can you also create an issue to add integration tests after merging?
instrumentation/github.com/go-sql-driver/mysql/splunkmysql/README.md
Show resolved
Hide resolved
instrumentation/github.com/go-sql-driver/mysql/splunkmysql/README.md
Outdated
Show resolved
Hide resolved
instrumentation/github.com/go-sql-driver/mysql/splunkmysql/example_test.go
Show resolved
Hide resolved
instrumentation/github.com/go-sql-driver/mysql/splunkmysql/example_test.go
Outdated
Show resolved
Hide resolved
I see some build issues, but other than that LGTM 👍 |
…mple_test.go Co-authored-by: Robert Pająk <[email protected]>
Add instrumentation for the
mysql
package.