Skip to content

Set splunk.distro.version attr in resource #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 28, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 27, 2022

@MrAlias MrAlias requested review from a team as code owners January 27, 2022 18:22
Copy link
Contributor

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a line in the CHANGELOG

@MrAlias MrAlias requested a review from a team as a code owner January 28, 2022 16:06
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2022

Codecov Report

Merging #332 (c56744e) into main (b3e4c19) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
- Coverage   79.14%   79.10%   -0.05%     
==========================================
  Files          54       54              
  Lines        2700     2709       +9     
==========================================
+ Hits         2137     2143       +6     
- Misses        521      523       +2     
- Partials       42       43       +1     
Flag Coverage Δ
Linux 79.10% <66.66%> (-0.05%) ⬇️
macOS ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
distro/otel.go 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e4c19...c56744e. Read the comment docs.

@MrAlias MrAlias enabled auto-merge (squash) January 28, 2022 16:17
@MrAlias MrAlias merged commit a61c279 into signalfx:main Jan 28, 2022
@MrAlias MrAlias deleted the splunk-distro-ver branch January 28, 2022 16:28
@MrAlias MrAlias mentioned this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants