Skip to content

Move Heroku buildpack to dedicated repo #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Move Heroku buildpack to dedicated repo #755

merged 1 commit into from
Sep 20, 2021

Conversation

flands
Copy link
Contributor

@flands flands commented Sep 19, 2021

No description provided.

@flands flands requested review from a team as code owners September 19, 2021 22:51
@dmitryax
Copy link
Contributor

dmitryax commented Sep 19, 2021

Why do we want to move Heroku to a dedicated repo? Last time we discussed the same for Ansible and agreed to stay here...

@flands
Copy link
Contributor Author

flands commented Sep 20, 2021

Because it does not work :) The way you push buildpacks is that the required directories need to be at the root level of the repo. I am not aware of a workaround -- appears to be how everyone else does it too.

@rmfitzpatrick
Copy link
Contributor

Another option we tried in the past when galaxy had the same requirements was to keep a ~mirror of the deployment at a new project and manually refresh its contents (https://github.com/signalfx/ansible-signalfx-agent). I think the two projects diverged almost immediately due to lack of clear coordination, so it probably would have been better to make the deployment directory its own repo and clone it from the relative path at the standalone project.

Unless there are clear reasons to keep the deployment in this project like shared, relative deps, updater scripts, or test infrastructure simply migrating is the easiest way.

@flands
Copy link
Contributor Author

flands commented Sep 20, 2021

No dependencies on this repo :)

@dmitryax
Copy link
Contributor

Sounds good! Let's move it away

@flands flands merged commit a8a27ff into main Sep 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the flands/heroku branch September 20, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants