Skip to content

Add readme for deploying collector to ECS EC2 #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2021
Merged

Add readme for deploying collector to ECS EC2 #642

merged 1 commit into from
Sep 2, 2021

Conversation

bjsignalfx
Copy link
Contributor

No description provided.

@bjsignalfx bjsignalfx requested review from a team as code owners August 19, 2021 04:15
dmitryax
dmitryax reviewed Aug 19, 2021
View reviewed changes
flands
flands reviewed Aug 19, 2021
View reviewed changes
Copy link
Contributor

@flands flands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be sure to open a task to add to data setup page as well

rmfitzpatrick
rmfitzpatrick reviewed Aug 23, 2021
View reviewed changes
rmfitzpatrick
rmfitzpatrick reviewed Aug 23, 2021
View reviewed changes
rmfitzpatrick
rmfitzpatrick reviewed Aug 23, 2021
View reviewed changes
@bjsignalfx bjsignalfx force-pushed the deploy-ecs-ec2 branch 3 times, most recently from dbe0567 to 8fe71ec Compare August 26, 2021 20:21
@mstumpfx
Copy link

Can you add a note somewhere in the README that for tracing-only environments users should disable the smartagent/ecs-metadata receiver? It's just not valid in a tracing-only deployment model since it sends metrics.

@bjsignalfx
Copy link
Contributor Author

Can you add a note somewhere in the README that for tracing-only environments users should disable the smartagent/ecs-metadata receiver? It's just not valid in a tracing-only deployment model since it sends metrics.

@mstumpfx is the note I added good?

dmitryax
dmitryax reviewed Aug 26, 2021
View reviewed changes
@bjsignalfx bjsignalfx force-pushed the deploy-ecs-ec2 branch 3 times, most recently from cff5645 to 8fd90b9 Compare August 27, 2021 18:32
rmfitzpatrick
rmfitzpatrick reviewed Aug 27, 2021
View reviewed changes
rmfitzpatrick
rmfitzpatrick reviewed Aug 30, 2021
View reviewed changes
@bjsignalfx bjsignalfx merged commit 65060f3 into main Sep 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the deploy-ecs-ec2 branch September 2, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flands flands flands left review comments

@dmitryax dmitryax dmitryax left review comments

@rmfitzpatrick rmfitzpatrick rmfitzpatrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bjsignalfx @mstumpfx @flands @dmitryax @rmfitzpatrick