-
Notifications
You must be signed in to change notification settings - Fork 166
[chore][ansible] Upgrade version tested for Windows #6288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
crobert-1
wants to merge
25
commits into
signalfx:main
Choose a base branch
from
crobert-1:upgrade_otel_ansible_windows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+102
−7
Draft
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8619232
[chore][ansible] Upgrade version tested for Windows
crobert-1 811a2fe
fix ansible lint
crobert-1 53429e9
touch log file
crobert-1 e6eeeba
change log_path to be a host path (rather than windows)
crobert-1 8e9e52b
debug: upload msi install logs to github artifact ouput
crobert-1 23f2659
Don't stop ansible deploy on failure, collector log file
crobert-1 296d8de
change path used for win install log file
crobert-1 1a355b3
use absolute path without substitutes
crobert-1 52e5047
use unique name for log files from windows ansible msi install
crobert-1 00769da
fail job if molecule test fails, but still upload logs
crobert-1 e76c5a4
Change to show step failure, but still execute uploading of logs
crobert-1 0badc94
Always fetch logs as github workflow determines whether to upload them
crobert-1 2794a05
Only upload log files if molecule tests failed
crobert-1 2336c72
Upload logs even if successful molecule test
crobert-1 4c93952
ignoring errors, upload all matching files, not directory
crobert-1 908277d
attempt to add timeout to msi install
crobert-1 95f3022
save async results file, give github artifacts unique names
crobert-1 4d26367
fix upload naming to include ansible version, add more log debugging
crobert-1 a6674a0
add win registry variable output
crobert-1 a262b68
use regex replace for surrounding MSI arg values with spaces
crobert-1 fc2151d
all tests failed with escaped double-quotes, test un-escaped
crobert-1 c83f83f
no escaping failed lint, try two backslashes for escaping
crobert-1 7b9b18e
separate out regex and replacement strings into vars
crobert-1 65cdf49
double escape didn't work, the group specifiers were broken. attempt …
crobert-1 a738a49
only use one backslash for group replacement regex
crobert-1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These logs are coming from the specific step of installing the MSI currently. We could potentially just upload logs on molecule test failure as that would save space, but if the failure messages aren't very clear it's helpful to have successful logs as well for comparing.
The log files aren't very big (~1.5MB each), so I think we should keep them for now.