Skip to content

[linux installer script] Deprecate Fluentd support #6264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2025

Conversation

crobert-1
Copy link
Contributor

@crobert-1 crobert-1 commented May 29, 2025

Description:

Add notes that the functionality has been deprecated in help output as well as log a message when the CLI option is used.

Testing:

$ ./install.sh --help
...
Fluentd [DEPRECATED]:
...
$ ./install.sh --with-fluentd
[WARNING] Fluentd support has been deprecated and will be removed in a future release. Please use native OTel receivers instead (e.g. the filelog receiver).
Please enter your Splunk access token:

@crobert-1 crobert-1 requested review from a team as code owners May 29, 2025 21:51
Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.75%. Comparing base (87bee7a) to head (2dcfef3).
Report is 1 commits behind head on main.

❌ Your project check has failed because the head coverage (34.75%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (87bee7a) and HEAD (2dcfef3). Click for more details.

HEAD has 32 uploads less than BASE
Flag BASE (87bee7a) HEAD (2dcfef3)
35 3
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6264       +/-   ##
===========================================
- Coverage   44.91%   34.75%   -10.16%     
===========================================
  Files         390      345       -45     
  Lines       27006    25122     -1884     
===========================================
- Hits        12129     8732     -3397     
- Misses      14009    15801     +1792     
+ Partials      868      589      -279     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crobert-1 crobert-1 force-pushed the deprecate_fluentd_linux_installer branch from 2dcfef3 to 151d9b4 Compare May 29, 2025 23:06
@crobert-1
Copy link
Contributor Author

lychee is failing on links unrelated to this PR, we should fix separately.

@crobert-1 crobert-1 merged commit d71ab41 into signalfx:main May 30, 2025
420 of 426 checks passed
@crobert-1 crobert-1 deleted the deprecate_fluentd_linux_installer branch May 30, 2025 17:52
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants