[chore][ansible] Fix failing Windows tests #6246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set python action version use working 2022 box for 2019, StefanScherer/windows_2016, increase memory and set python deps Clean cache fix vagrant box versions set valid versions for vagrant boxes Different requirements.txt files for different ansible versions Use StefanScherer/windows_2019 for 2019
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6246 +/- ##
==========================================
+ Coverage 44.82% 44.86% +0.03%
==========================================
Files 390 390
Lines 26983 26983
==========================================
+ Hits 12096 12106 +10
+ Misses 14017 14009 -8
+ Partials 870 868 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crobert-1
force-pushed
the
ansible_cherry_picked
branch
from
21f1f19 to
90ee27f
Compare
dloucasfx
approved these changes
May 23, 2025
| - name: free after clean cache | ||
| run: | | ||
| free -h | ||
|
|
There was a problem hiding this comment.
Nit;
Shall we add a debug flag to display this info if needed?
There was a problem hiding this comment.
I thought about it but I'm thinking of keeping it for now. My thought process is that with flaky failures we ideally want this output when it fails, as it may pass the next time when it's run with debugging.
I'd be happy to remove in the future if it's too much noise or use a debug flag if you disagree 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Ansible tests on Windows recently started failing with
VERR_NO_LOW_MEMORYandVERR_NO_CONT_MEMORYerrors. This was not caused by any change in our repository, the likely culprit is the GitHub workflow doingapt updateand picking up new dependencies that broke the vagrant box configurations being used. The changes included here are the minimal changes required to reduce flakiness and get Windows tests passing again.aptandpythondependencies.