Skip to content

[chore][puppet tests] Upgrade minimum Node.js version to v18 #6238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

crobert-1
Copy link
Contributor

Description:

Failure link:

Notice: /Stage[main]/Splunk_otel_collector/Exec[Install splunk-otel-js]/returns: npm WARN EBADENGINE Unsupported engine {
Notice: /Stage[main]/Splunk_otel_collector/Exec[Install splunk-otel-js]/returns: npm WARN EBADENGINE   package: '@splunk/[email protected]',
Notice: /Stage[main]/Splunk_otel_collector/Exec[Install splunk-otel-js]/returns: npm WARN EBADENGINE   required: { node: '>=18' },
Notice: /Stage[main]/Splunk_otel_collector/Exec[Install splunk-otel-js]/returns: npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
Notice: /Stage[main]/Splunk_otel_collector/Exec[Install splunk-otel-js]/returns: npm WARN EBADENGINE }
Notice: /Stage[main]/Splunk_otel_collector/Exec[Install splunk-otel-js]/returns: npm notice 
Notice: /Stage[main]/Splunk_otel_collector/Exec[Install splunk-otel-js]/returns: npm notice New major version of npm available! 8.19.4 -> 11.4.0
Notice: /Stage[main]/Splunk_otel_collector/Exec[Install splunk-otel-js]/returns: npm notice Changelog: <https://github.com/npm/cli/releases/tag/v11.4.0>
Notice: /Stage[main]/Splunk_otel_collector/Exec[Install splunk-otel-js]/returns: npm notice Run `npm install -g [email protected]` to update!
Notice: /Stage[main]/Splunk_otel_collector/Exec[Install splunk-otel-js]/returns: npm notice 
Notice: /Stage[main]/Splunk_otel_collector/Exec[Install splunk-otel-js]/returns: npm ERR! code 1

Updating all nodejs version references to v18.

Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.46%. Comparing base (28afaf8) to head (96eef97).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6238      +/-   ##
==========================================
+ Coverage   44.38%   44.46%   +0.07%     
==========================================
  Files         390      390              
  Lines       26986    26986              
==========================================
+ Hits        11979    12000      +21     
+ Misses      14162    14145      -17     
+ Partials      845      841       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crobert-1 crobert-1 marked this pull request as ready for review May 20, 2025 17:58
@crobert-1 crobert-1 requested review from a team as code owners May 20, 2025 17:58
@crobert-1 crobert-1 merged commit 2a8dc5f into signalfx:main May 20, 2025
177 checks passed
@crobert-1 crobert-1 deleted the fix_puppet_tests branch May 20, 2025 18:52
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants