Skip to content

[chore][installer-script-test] Upgrade minimum version of Node.js to v18 in testing #6235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025
Merged

[chore][installer-script-test] Upgrade minimum version of Node.js to v18 in testing #6235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
260b29d
[chore][installer-tests] Upgrade minimum node version to 18
crobert-1 May 19, 2025
1906aca
Fix another v16 ref
crobert-1 May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packaging/tests/installer_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ def test_installer_with_instrumentation_default(distro, arch, method):
pytest.skip("opensuse-12 arm64 no longer supported")

# minimum supported node version required for profiling
node_version = 16
node_version = 18
if arch == "arm64" and distro in ("centos-7"):
# g++ for these distros is too old to build/compile splunk-otel-js with node v16:
# g++: error: unrecognized command line option '-std=gnu++14'
Expand Down Expand Up @@ -498,7 +498,7 @@ def test_installer_with_instrumentation_custom(distro, arch, method, sdk):
pytest.skip("opensuse-12 arm64 no longer supported")

# minimum supported node version required for profiling
node_version = 16
node_version = 18
if arch == "arm64" and distro in ("centos-7"):
# g++ for these distros is too old to build/compile splunk-otel-js with node v16:
# g++: error: unrecognized command line option '-std=gnu++14'
Expand Down