Skip to content

[chore] [receiver/smartagent] Don't call validate explicitly #6192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

dmitryax
Copy link
Contributor

@dmitryax dmitryax commented May 3, 2025

Implement xconfmap.Validator interface instead so it's called automatically after unmarshaling

@dmitryax dmitryax requested review from a team as code owners May 3, 2025 23:21
@dmitryax dmitryax force-pushed the simplify-smartagent-receiver-validate branch from 074c916 to 5cdf59e Compare May 4, 2025 00:40
Copy link

codecov bot commented May 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.36%. Comparing base (20deed6) to head (03e8ae6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6192      +/-   ##
==========================================
- Coverage   44.44%   44.36%   -0.08%     
==========================================
  Files         390      390              
  Lines       26993    26986       -7     
==========================================
- Hits        11997    11973      -24     
- Misses      14156    14167      +11     
- Partials      840      846       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Implement xconfmap.Validator interface instead so it's called automatically after unmarshaling
@dmitryax dmitryax force-pushed the simplify-smartagent-receiver-validate branch from 5cdf59e to 03e8ae6 Compare May 4, 2025 00:57
@dmitryax dmitryax merged commit 4068b24 into main May 5, 2025
79 checks passed
@dmitryax dmitryax deleted the simplify-smartagent-receiver-validate branch May 5, 2025 15:05
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants