Skip to content

[chore] Mark github.com/signalfx/signalfx-agent module as local #6189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

dmitryax
Copy link
Contributor

@dmitryax dmitryax commented May 2, 2025

Going forward we need to update all the usages of github.com/signalfx/signalfx-agent to github.com/signalfx/splunk-otel-collector/internal/signalfx-agent

@dmitryax dmitryax requested review from a team as code owners May 2, 2025 23:45
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.35%. Comparing base (8db19d3) to head (4040706).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6189      +/-   ##
==========================================
- Coverage   44.41%   44.35%   -0.06%     
==========================================
  Files         390      390              
  Lines       26986    26986              
==========================================
- Hits        11985    11969      -16     
- Misses      14158    14171      +13     
- Partials      843      846       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dmitryax dmitryax force-pushed the mark-smart-agent-module-local branch from b928490 to 4a3956f Compare May 5, 2025 15:28
Copy link
Contributor

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thought process makes sense to me, LGTM once lint and the rest of CI is passing

@dmitryax dmitryax force-pushed the mark-smart-agent-module-local branch from 4a3956f to 2a0efdf Compare May 5, 2025 16:54
Going forward we need to update all the usages of github.com/signalfx/signalfx-agent to github.com/signalfx/splunk-otel-collector/internal/signalfx-agent
@dmitryax dmitryax force-pushed the mark-smart-agent-module-local branch from 2a0efdf to 4040706 Compare May 5, 2025 19:56
@dmitryax dmitryax merged commit 3dac036 into main May 5, 2025
233 checks passed
@dmitryax dmitryax deleted the mark-smart-agent-module-local branch May 5, 2025 21:08
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants