Skip to content

update rules to not use deprecated syntax and allow for manual pushes #6184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

hughesjj
Copy link
Contributor

  1. only/except is deprecated
  2. Allows for manual runs of technical addon branches if you manually protect them

@hughesjj hughesjj force-pushed the update_ci/update_trigger_filter branch from 2d06c81 to 5ee90d5 Compare April 30, 2025 23:57
@hughesjj hughesjj force-pushed the update_ci/update_trigger_filter branch from 5ee90d5 to 0a6ffbe Compare April 30, 2025 23:59
@hughesjj hughesjj marked this pull request as ready for review April 30, 2025 23:59
@hughesjj hughesjj requested review from a team as code owners April 30, 2025 23:59
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the GitLab rules feature, but, the implied logic LGTM

Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.06%. Comparing base (baa1ef8) to head (0a6ffbe).

❌ Your project check has failed because the head coverage (35.06%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (baa1ef8) and HEAD (0a6ffbe). Click for more details.

HEAD has 32 uploads less than BASE
Flag BASE (baa1ef8) HEAD (0a6ffbe)
34 2
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6184      +/-   ##
==========================================
- Coverage   44.52%   35.06%   -9.46%     
==========================================
  Files         390      346      -44     
  Lines       27014    25148    -1866     
==========================================
- Hits        12028     8819    -3209     
- Misses      14147    15755    +1608     
+ Partials      839      574     -265     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hughesjj hughesjj merged commit 94543e3 into main May 1, 2025
29 of 34 checks passed
@hughesjj hughesjj deleted the update_ci/update_trigger_filter branch May 1, 2025 00:12
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants