Skip to content

[chore][envoy discovery] Extend integration test timeout #6180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

crobert-1
Copy link
Contributor

Description:

This test is flaky in GitHub CI and when run locally. Successful runs often take 20+ seconds, which gets close to the timeout as it is. Other discovery tests have a timeout of 1 or 2 minutes, so this update simple aligns this test with others.

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.45%. Comparing base (4a5ec07) to head (bcdc1bb).
Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (4a5ec07) and HEAD (bcdc1bb). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (4a5ec07) HEAD (bcdc1bb)
35 31
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6180       +/-   ##
===========================================
- Coverage   44.49%   34.45%   -10.04%     
===========================================
  Files         391      390        -1     
  Lines       27034    27014       -20     
===========================================
- Hits        12029     9308     -2721     
- Misses      14165    17083     +2918     
+ Partials      840      623      -217     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crobert-1 crobert-1 marked this pull request as ready for review April 30, 2025 20:01
@crobert-1 crobert-1 requested review from a team as code owners April 30, 2025 20:01
@crobert-1 crobert-1 merged commit c334e29 into signalfx:main Apr 30, 2025
77 of 78 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants