Skip to content

[chore] Upgrade NodeJS instrumentation to latest #6162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2025

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Apr 21, 2025

Supersedes #5800 since additional changes were needed:

  • Minimal version supported by the instrumentation is Node v18
  • Removal of ubuntu-bionic from the test matrix since Node v18 is not available on the package manager for that OS version

Keeping #5800 open until this one is merged to avoid a creation of a new PR updating the instrumentation.

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.81%. Comparing base (f0c63e9) to head (f8b11de).
Report is 2 commits behind head on main.

❌ Your project status has failed because the head coverage (28.81%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (f0c63e9) and HEAD (f8b11de). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (f0c63e9) HEAD (f8b11de)
35 30
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6162       +/-   ##
===========================================
- Coverage   44.48%   28.81%   -15.68%     
===========================================
  Files         391      375       -16     
  Lines       27034    26183      -851     
===========================================
- Hits        12027     7545     -4482     
- Misses      14168    17800     +3632     
+ Partials      839      838        -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pjanotti pjanotti changed the title [DRAFT][chore] Upgrade NodeJS instrumentation to latest [chore] Upgrade NodeJS instrumentation to latest Apr 22, 2025
@pjanotti pjanotti marked this pull request as ready for review April 22, 2025 02:22
@pjanotti pjanotti requested review from a team as code owners April 22, 2025 02:22
@pjanotti pjanotti merged commit dc9b260 into signalfx:main Apr 22, 2025
211 of 212 checks passed
@pjanotti pjanotti deleted the upgrade-nodejs-instrumentation branch April 22, 2025 15:26
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants