Skip to content

[chore][codecov] Add to integration-test #6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 43 commits into from

Conversation

crobert-1
Copy link
Contributor

@crobert-1 crobert-1 commented Mar 31, 2025

NOTE: This PR will not be reviewed or merged. I'm splitting it up to make reviewing easier. This simply shows the end result of adding code coverage to all integration tests.

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 76.47059% with 24 lines in your changes missing coverage. Please review.

Project coverage is 44.22%. Comparing base (0b08db2) to head (d013ad7).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
tests/testutils/golden.go 68.96% 7 Missing and 2 partials ⚠️
tests/testutils/testcase.go 82.69% 7 Missing and 2 partials ⚠️
tests/internal/discoverytest/discoverytest.go 71.42% 5 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (76.47%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6074      +/-   ##
==========================================
+ Coverage   34.54%   44.22%   +9.67%     
==========================================
  Files         347      391      +44     
  Lines       25188    27082    +1894     
==========================================
+ Hits         8702    11976    +3274     
+ Misses      15921    14265    -1656     
- Partials      565      841     +276     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crobert-1 crobert-1 force-pushed the add_codecov_integration branch 2 times, most recently from 5eab2aa to 9528047 Compare April 3, 2025 22:42
@crobert-1 crobert-1 force-pushed the add_codecov_integration branch from af4cbbb to ca6fc0c Compare April 14, 2025 16:29
@crobert-1 crobert-1 force-pushed the add_codecov_integration branch 4 times, most recently from be3dd7d to 27db036 Compare April 18, 2025 17:23
@crobert-1 crobert-1 force-pushed the add_codecov_integration branch from 68c1eb5 to d013ad7 Compare April 18, 2025 18:38
@crobert-1
Copy link
Contributor Author

Actual functionality has been cleaned up and merged into main, closing this.

@crobert-1 crobert-1 closed this Apr 21, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant