Skip to content

Make govulncheck run more reliable #6021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 25, 2025

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Mar 21, 2025

Broken down the execution per packages, but, in the end that was not enough and had to change the scan scope to package. The main disadvantage of that is that with symbol the tool can better asses if the code uses a function or code pattern, with package scan we may have to do some follow up to understand if/how the vulnerability should be treated. This is not ideal, the alternative would be have some larger runner that could take the memory hit of the tool with the symbol scan.

Although the breakdown in packages was not enough I opted to keep it because it lowers the chances of more OOMs in the future and also make easier to run it locally when investigating issues. Similar to the changes on the Makefile: in the end it was not necessary to solve the problem, but, since it was already in place it is good to have it at hand.

Example run: https://github.com/signalfx/splunk-otel-collector/actions/runs/14010129646/job/39228876676?pr=6021

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

* Update go version to 1.23.7

* Update version for GH workflows that had " or ' delimiters

* Use GO_VERSION pattern on gitlab-ci too

* make gendependabot
@pjanotti pjanotti force-pushed the make-govulncheck-run-reliable branch from 36ca070 to e6dafa5 Compare March 22, 2025 15:42
@pjanotti pjanotti marked this pull request as ready for review March 22, 2025 16:03
@pjanotti pjanotti requested review from a team as code owners March 22, 2025 16:03
Copy link
Contributor

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly concerned about more GitHub workflow code and scripts to maintain, but this seems like the best option with the flakiness. We can revisit later if it becomes challenging.

@pjanotti pjanotti merged commit 1d04ae8 into signalfx:main Mar 25, 2025
215 of 217 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
@pjanotti
Copy link
Contributor Author

@crobert-1 just to be clear, we can really get rid of all of these by just setting the scan mode to be package instead of symbol which this PR had to do anyway to get reliable runs. Targeting the packages seem to be more about the future if the code base grows something that we should avoid if possible.

@pjanotti pjanotti deleted the make-govulncheck-run-reliable branch March 28, 2025 02:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants