istio k8s discovery #5854
Merged
istio k8s discovery #5854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
istio
branch
5 times, most recently
from
0b8aeda to
f331816
Compare
hughesjj
previously requested changes
Mar 19, 2025
cmd/otelcol/config/collector/config.d.linux/receivers/istio.discovery.yaml
Outdated
Show resolved
Hide resolved
|
Converted to draft since I am working on fixes for the PR. The discovery config needs updates to work with istio-proxy, gateways and pilot. |
jinja2
reviewed
Mar 26, 2025
| default: | ||
| config: | ||
| scrape_configs: | ||
| - job_name: 'istio' |
There was a problem hiding this comment.
This shows up as service.name in the final metrics. Any feedback on a better name is welcome.
jinja2
reviewed
Mar 26, 2025
internal/confmapprovider/discovery/bundle/bundle.d/receivers/istio.discovery.yaml.tmpl
Outdated
Show resolved
Hide resolved
jinja2
reviewed
Mar 26, 2025
jinja2
reviewed
Mar 28, 2025
| {{ receiver "prometheus/istio" }}: | ||
| enabled: true | ||
| rule: | ||
| k8s_observer: type == "pod" and ("istio.io/rev" in annotations or labels["istio"] == "pilot" or name matches "istio.*") |
There was a problem hiding this comment.
I am not checking for the std annotations["prometheus.io/scrape"] == "true". My thinking is that with discovery mode we are not expecting users to do the pre-work of adding these, but then on the other hand, this would be an easy way for users to opt-out certain pods.
dmitryax
reviewed
Mar 28, 2025
cmd/otelcol/config/collector/config.d.linux/receivers/istio.discovery.yaml
Outdated
Show resolved
Hide resolved
dmitryax
approved these changes
Mar 31, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds istio k8s discovery with a pod.container rule to connect to any istio container and extract metrics.