Skip to content

Remove deployment support for Debian versions that reached EOL #5804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/ansible.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ jobs:
- amazonlinux2023
- centos8
- centos9
- debian9
- debian10
- debian11
- debian12
- opensuse12
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/puppet-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
distro=$(for d in $dockerfiles; do echo -n "\"$d\","; done)
puppet_release='"6","7","8"'
with_instrumentation='"true","false"'
exclude='{"DISTRO": "debian-stretch", "PUPPET_RELEASE": "8"}, {"DISTRO": "ubuntu-xenial", "PUPPET_RELEASE": "8"}' # puppet 8 not supported for these distros
exclude='{"DISTRO": "ubuntu-xenial", "PUPPET_RELEASE": "8"}' # puppet 8 not supported for this distro
matrix="{\"DISTRO\": [${distro%,}], \"PUPPET_RELEASE\": [${puppet_release}], \"WITH_INSTRUMENTATION\": [${with_instrumentation}], \"exclude\": [${exclude}]}"
echo "$matrix" | jq
echo "matrix=${matrix}" >> $GITHUB_OUTPUT
Expand Down
4 changes: 2 additions & 2 deletions deployments/ansible/molecule/config/vagrant.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ platforms:
box: ubuntu/focal64
- name: centos8
box: centos/8
- name: buster64
box: debian/buster64
- name: bookworm64
box: debian/bookworm64
- name: amazonlinux
box: bento/amazonlinux-2
provisioner:
Expand Down
4 changes: 0 additions & 4 deletions deployments/ansible/molecule/default/Dockerfile.j2
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
{% if item.image not in ["opensuse12", "opensuse15", "centos9"] %}
FROM geerlingguy/docker-{{ item.image }}-ansible:latest
{% if item.image == "debian9" %}
RUN sed -i 's|http://.*.debian.org|http://archive.debian.org|' /etc/apt/sources.list
RUN sed -i '/stretch-updates/d' /etc/apt/sources.list
{% endif %}
{% elif item.image == "centos9" %}
FROM quay.io/centos/centos:stream9
ENV container docker
Expand Down
3 changes: 1 addition & 2 deletions deployments/ansible/roles/collector/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,7 @@ which allows setting up a proxy to download the collector binaries.
(**default:** `false`)

- `td_agent_version`: Version of td-agent (fluentd package) that will be
installed (**default:** `3.7.1` for Debian stretch and `4.3.2` for other
distros)
installed (**default:** `4.3.2`)

- `splunk_fluentd_config`: Path to the fluentd config file on the remote host.
(**default:** `/etc/otel/collector/fluentd/fluent.conf` on Linux,
Expand Down
2 changes: 1 addition & 1 deletion deployments/ansible/roles/collector/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ start_service: true
splunk_skip_repo: false

# Explicitly set version of td-agent,
# By default: 3.7.1 for Debian stretch and 4.3.2 for other distros.
# By default: 4.3.2
td_agent_version: ""

# Default path on Linux: "/etc/otel/collector/fluentd/fluent.conf".
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
td_agent_version: |-
{%- if td_agent_version -%}
{{ td_agent_version }}
{%- elif ansible_distribution_release == "stretch" -%}
3.7.1-0
{%- elif ansible_os_family == "Debian" -%}
4.3.2-1
{%- else -%}
Expand Down
3 changes: 1 addition & 2 deletions deployments/chef/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,7 @@ required `splunk_access_token` attribute and some optional attributes:

- `fluentd_version`: Version of the [td-agent](
https://www.fluentd.org/download) (Fluentd) package to install (**default:**
`3.7.1` for Debian stretch, and `4.3.1` for all other Linux distros and
Windows)
`4.3.1` for all Linux distros and Windows)

- `fluentd_config_source`: Source path to the Fluentd config file. This file
will be copied to the `fluentd_config_dest` path on the node. See the
Expand Down
7 changes: 1 addition & 6 deletions deployments/chef/attributes/default.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,7 @@

default['splunk_otel_collector']['with_fluentd'] = false
default['splunk_otel_collector']['fluentd_version'] = if platform_family?('debian')
case node['lsb']['codename']
when 'stretch'
'3.7.1-0'
else
'4.3.2-1'
end
'4.3.2-1'
else
'4.3.2'
end
Expand Down
13 changes: 0 additions & 13 deletions deployments/chef/kitchen.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,6 @@ platforms:
image: dokken/rockylinux-9
pid_one_command: /usr/lib/systemd/systemd

- name: debian-9
driver:
image: dokken/debian-9
intermediate_instructions: |
RUN sed -i 's|http://.*.debian.org|http://archive.debian.org|' /etc/apt/sources.list
RUN sed -i '/stretch-updates/d' /etc/apt/sources.list
pid_one_command: /bin/systemd

- name: debian-10
driver:
image: dokken/debian-10
pid_one_command: /bin/systemd

- name: debian-11
driver:
image: dokken/debian-11
Expand Down
6 changes: 1 addition & 5 deletions deployments/puppet/manifests/params.pp
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Class for default param values based on OS
class splunk_otel_collector::params {
$fluentd_version_default = '4.3.2'
$fluentd_version_stretch = '3.7.1-0'
$collector_additional_env_vars = {}

if $facts['os']['family'] == 'redhat' or $facts['os']['family'] == 'debian' or $facts['os']['family'] == 'suse' {
Expand All @@ -14,10 +13,7 @@
$collector_config_dest = $collector_config_source
$fluentd_base_url = 'https://packages.treasuredata.com'
if $facts['os']['family'] == 'debian' {
$fluentd_version = downcase($facts['os']['distro']['codename']) ? {
'stretch' => $fluentd_version_stretch,
default => "${fluentd_version_default}-1",
}
$fluentd_version = "${fluentd_version_default}-1"
} else {
$fluentd_version = $fluentd_version_default
}
Expand Down
3 changes: 1 addition & 2 deletions deployments/salt/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,7 @@ splunk-otel-collector:

- `td_agent_version`: Version of [td-agent](
https://td-agent-package-browser.herokuapp.com/) (fluentd package) that will
be installed (**default:** `3.7.1-0` for Debian 9, and `4.3.0` for other
distros)
be installed (**default:** `4.3.0`)

- `splunk_fluentd_config`: Path to the fluentd config file on the remote host.
(**default:** `/etc/otel/collector/fluentd/fluent.conf`)
Expand Down
2 changes: 0 additions & 2 deletions deployments/salt/splunk-otel-collector/fluentd.sls
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

{% if td_agent_version %}
{{ td_agent_version }}
{%- elif grains['oscodename'] == 'stretch' %}
{% set td_agent_version = '3.7.1-0' %}
{%- elif grains['os_family'] == 'Debian' %}
{% set td_agent_version = '4.3.2-1' %}
{%- else %}
Expand Down
17 changes: 2 additions & 15 deletions packaging/installer/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,6 @@ get_distro_codename() {

if [ "$distro" = "debian" ] && [ -z "$codename" ]; then
case "$( get_distro_version )" in
9)
codename="stretch"
;;
10)
codename="buster"
;;
11)
codename="bullseye"
;;
Expand Down Expand Up @@ -97,15 +91,10 @@ default_listen_interface="0.0.0.0"

default_collector_version="latest"
default_td_agent_version="4.3.2"
default_td_agent_version_stretch="3.7.1-0"

default_service_user="splunk-otel-collector"
default_service_group="splunk-otel-collector"

if [ "$distro_codename" = "stretch" ]; then
default_td_agent_version="$default_td_agent_version_stretch"
fi

preload_path="/etc/ld.so.preload"
default_instrumentation_version="latest"
default_deployment_environment=""
Expand Down Expand Up @@ -753,9 +742,7 @@ install() {
apt-get -y update
install_apt_package "splunk-otel-collector" "$collector_version"
if [ -n "$td_agent_version" ]; then
if [ "$distro_codename" != "stretch" ]; then
td_agent_version="${td_agent_version}-1"
fi
td_agent_version="${td_agent_version}-1"
if [ "$skip_fluentd_repo" = "false" ]; then
install_td_agent_apt_repo "$td_agent_version"
fi
Expand Down Expand Up @@ -1039,7 +1026,7 @@ distro_is_supported() {
;;
debian)
case "$distro_codename" in
bookworm|bullseye|buster|stretch)
bookworm|bullseye)
return 0
;;
esac
Expand Down

This file was deleted.

This file was deleted.

2 changes: 1 addition & 1 deletion packaging/tests/deployments/puppet/puppet_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def verify_env_file(container, api_url=SPLUNK_API_URL, ingest_url=SPLUNK_INGEST_


def skip_if_necessary(distro, puppet_release):
if distro in ("debian-stretch", "ubuntu-xenial") and int(puppet_release) >= 8:
if distro == "ubuntu-xenial" and int(puppet_release) >= 8:
pytest.skip(f"Puppet {puppet_release} not supported for {distro}")


Expand Down
5 changes: 0 additions & 5 deletions packaging/tests/deployments/salt/images/Dockerfile.deb
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ ENV DEBIAN_FRONTEND=noninteractive
ENV SALT_VERSION=latest
ENV NODE_VERSION=16.20.2

# repo update for debian:stretch
RUN if [ ${DISTRO_IMAGE} = "debian:stretch" ]; then \
sed -i 's|http://.*.debian.org|http://archive.debian.org|' /etc/apt/sources.list && \
sed -i '/stretch-updates/d' /etc/apt/sources.list; fi

RUN apt-get update && apt-get upgrade -y -o DPkg::Options::=--force-confold
RUN apt-get install -y software-properties-common ca-certificates wget curl apt-transport-https python3-pip vim systemd procps

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
deb:
debian-bullseye: ["DISTRO_IMAGE=debian:bullseye"]
debian-buster: ["DISTRO_IMAGE=debian:buster"]
debian-stretch: ["DISTRO_IMAGE=debian:stretch"]
ubunu-bionic: ["DISTRO_IMAGE=ubuntu:18.04"]
ubuntu-focal: ["DISTRO_IMAGE=ubuntu:20.04"]
ubuntu-jammy: ["DISTRO_IMAGE=ubuntu:22.04"]
Expand Down
24 changes: 0 additions & 24 deletions packaging/tests/images/deb/Dockerfile.debian-buster

This file was deleted.

27 changes: 0 additions & 27 deletions packaging/tests/images/deb/Dockerfile.debian-stretch

This file was deleted.

Loading
Loading