Skip to content

Update to use the ballast memory instead of the flag #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rmfitzpatrick merged 1 commit into from
Jul 23, 2021
Merged

Update to use the ballast memory instead of the flag #567

rmfitzpatrick merged 1 commit into from
Jul 23, 2021

Conversation

@bogdandrutu
Copy link
Contributor

@bogdandrutu bogdandrutu commented Jul 22, 2021

  • The memory_ballast extension is the only way to configure ballast starting with v0.31.0 of the collector;
  • The memory_limiter processor accesses the ballast directly from the config, no need to set ballast_memory_size anymore;

@bogdandrutu bogdandrutu requested review from a team as code owners July 22, 2021 19:45
tigrannajaryan
tigrannajaryan approved these changes Jul 22, 2021
View reviewed changes
@bogdandrutu
Copy link
Contributor Author

bogdandrutu commented Jul 22, 2021

@tigrannajaryan I extracted the upgrade in a separate PR that this PR depends on #568

@bogdandrutu
Update to use the ballast memory instead of the flag:
dc7cf35 
* The memory_ballast extension is the only way to configure ballast starting with v0.31.0 of the collector;
* The memory_limiter processor accesses the ballast directly from the config, no need to set ballast_memory_size anymore;

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Copy link
Contributor Author

bogdandrutu commented Jul 22, 2021

@tigrannajaryan I had to re-write the tests to make sure I am not breaking anything :)

@tigrannajaryan
Copy link
Contributor

tigrannajaryan commented Jul 23, 2021

Looks like I don't have merging rights.

@bogdandrutu
Copy link
Contributor Author

bogdandrutu commented Jul 23, 2021

@tigrannajaryan not even approving rights :))

@rmfitzpatrick rmfitzpatrick merged commit 5f8dec7 into signalfx:main Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

+1 more reviewer

@rmfitzpatrick rmfitzpatrick rmfitzpatrick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bogdandrutu @tigrannajaryan @rmfitzpatrick