Skip to content

Replace the SAPM exporter with OTLP HTTP in default configs #5588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Dec 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
ead2c04
switch from sapm to otlphttp as default
asreehari-splunk Nov 7, 2024
70a453a
missing update
asreehari-splunk Nov 18, 2024
1df9f57
update trace url for chef tests
asreehari-splunk Nov 18, 2024
22d4438
update trace endpoint for sapm
asreehari-splunk Nov 18, 2024
be25146
Updating zeroconfig\windows tests
pjanotti Nov 20, 2024
16eba48
zeroconfig/windows: network needs to be set as "external"
pjanotti Nov 20, 2024
a5989e0
switch from sapm to otlphttp as default
asreehari-splunk Nov 7, 2024
0367e2a
missing update
asreehari-splunk Nov 18, 2024
6205f06
update trace url for chef tests
asreehari-splunk Nov 18, 2024
0363330
update trace endpoint for sapm
asreehari-splunk Nov 18, 2024
26fc39f
Updating zeroconfig\windows tests
pjanotti Nov 20, 2024
e109170
zeroconfig/windows: network needs to be set as "external"
pjanotti Nov 20, 2024
a3fe7c1
comment out provo mirror
asreehari-splunk Nov 20, 2024
d05fd07
Merge branch 'sapm_to_otlphttp' of github.com:asreehari-splunk/splunk…
pjanotti Nov 22, 2024
f5dd888
get info about docker compose error
pjanotti Nov 22, 2024
db06c59
Add files missing to docker compose build
pjanotti Nov 22, 2024
61c1041
Build the ASP.NET app
pjanotti Nov 23, 2024
0871382
Revert commits to investigate docker compose error
pjanotti Nov 23, 2024
42b6377
Restore parts of docker-compose.yaml
pjanotti Nov 23, 2024
e4286c3
use trace_url for traces endpoint
asreehari-splunk Nov 25, 2024
798407a
Merge branch 'main' into sapm_to_otlphttp
asreehari-splunk Dec 4, 2024
f5fcd0f
Merge branch 'main' into sapm_to_otlphttp
asreehari-splunk Dec 10, 2024
d4aae4d
update test to match endpoint
asreehari-splunk Dec 11, 2024
ec80ea2
metrics endpoint is not required
asreehari-splunk Dec 12, 2024
3cbc174
Update cmd/otelcol/config/collector/ecs_ec2_config.yaml
dmitryax Dec 12, 2024
6e54e6c
update other fips configs
asreehari-splunk Dec 13, 2024
f0f3e3b
Merge branch 'main' into sapm_to_otlphttp
asreehari-splunk Dec 13, 2024
017caa3
update TA configs with otlphttp exporter
asreehari-splunk Dec 13, 2024
cb671b4
Merge branch 'main' into sapm_to_otlphttp
dmitryax Dec 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### 🛑 Breaking changes 🛑

- (Splunk) Change default traces exporter to otlphttp exporter. ([#5588](https://github.com/signalfx/splunk-otel-collector/pull/5588)).

### 🚀 New components 🚀

- (Splunk) Add `filestats` receiver ([#5229](https://github.com/signalfx/splunk-otel-collector/pull/5229))
Expand Down Expand Up @@ -38,6 +42,7 @@
- (Splunk) Deprecate the collectd/solr monitor. Please use the [jmxreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/jmxreceiver) with the solr target system instead. ([#5539](https://github.com/signalfx/splunk-otel-collector/pull/5539))
- (Splunk) Deprecate the collectd/tomcat monitor. Please use the [jmxreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/jmxreceiver) with the tomcat target system instead. ([#5539](https://github.com/signalfx/splunk-otel-collector/pull/5539))


## v0.114.0

### 💡 Enhancements 💡
Expand Down
20 changes: 20 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,26 @@ manually before the backward compatibility is dropped. For every configuration u
[the default agent config](https://github.com/signalfx/splunk-otel-collector/blob/main/cmd/otelcol/config/collector/agent_config.yaml)
as a reference.

### From 0.114.0 to 0.115.0

- The sapm exporter still works as before but has been deprecated. Use the otlphttp exporter instead

1. Replace the `sapm` exporter with `otlphttp` exporter using the following configuration
```yaml
otlphttp:
traces_endpoint: "${SPLUNK_INGEST_URL}/v2/trace/otlp"
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"
```
2. Update traces pipeline to use otlphttp exporter instead of sapm:
```
service:
pipelines:
traces:
exporters: [otlphttp, signalfx]
```


### From 0.96.1 to 0.97.0

- `memory_ballast` is no longer effective. The garbage collection is now controlled by the soft memory limit set to 90%
Expand Down
17 changes: 9 additions & 8 deletions cmd/otelcol/config/collector/agent_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,10 @@ processors:

exporters:
# Traces
sapm:
access_token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "${SPLUNK_INGEST_URL}/v2/trace"
otlphttp:
traces_endpoint: "${SPLUNK_INGEST_URL}/v2/trace/otlp"
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"
# Metrics + Events
signalfx:
access_token: "${SPLUNK_ACCESS_TOKEN}"
Expand Down Expand Up @@ -164,7 +165,7 @@ exporters:
endpoint: "${SPLUNK_INGEST_URL}/v1/log"
log_data_enabled: false
# Send to gateway
otlp:
otlp/gateway:
endpoint: "${SPLUNK_GATEWAY_URL}:4317"
tls:
insecure: true
Expand All @@ -182,15 +183,15 @@ service:
- batch
- resourcedetection
#- resource/add_environment
exporters: [sapm, signalfx]
exporters: [otlphttp, signalfx]
# Use instead when sending to gateway
#exporters: [otlp, signalfx]
#exporters: [otlp/gateway, signalfx]
metrics:
receivers: [hostmetrics, otlp, signalfx]
processors: [memory_limiter, batch, resourcedetection]
exporters: [signalfx]
# Use instead when sending to gateway
#exporters: [otlp]
#exporters: [otlp/gateway]
metrics/internal:
receivers: [prometheus/internal]
processors: [memory_limiter, batch, resourcedetection, resource/add_mode]
Expand All @@ -215,4 +216,4 @@ service:
#- resource/add_environment
exporters: [splunk_hec, splunk_hec/profiling]
# Use instead when sending to gateway
#exporters: [otlp]
#exporters: [otlp/gateway]
10 changes: 5 additions & 5 deletions cmd/otelcol/config/collector/ecs_ec2_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,10 @@ processors:

exporters:
# Traces
sapm:
access_token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "https://ingest.${SPLUNK_REALM}.signalfx.com/v2/trace"
otlphttp:
traces_endpoint: "${SPLUNK_INGEST_URL}/v2/trace/otlp"
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"
# Metrics + Events
signalfx:
access_token: "${SPLUNK_ACCESS_TOKEN}"
Expand All @@ -129,7 +130,6 @@ exporters:
token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "${SPLUNK_INGEST_URL}/v1/log"
log_data_enabled: false

service:
extensions: [health_check, http_forwarder, zpages]
pipelines:
Expand All @@ -140,7 +140,7 @@ service:
- batch
- resourcedetection
#- resource/add_environment
exporters: [sapm, signalfx]
exporters: [otlphttp, signalfx]
metrics:
receivers: [hostmetrics, otlp, signalfx, awsecscontainermetrics]
processors: [memory_limiter, batch, filter, resourcedetection]
Expand Down
9 changes: 5 additions & 4 deletions cmd/otelcol/config/collector/fargate_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,10 @@ processors:

exporters:
# Traces
sapm:
access_token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "https://ingest.${SPLUNK_REALM}.signalfx.com/v2/trace"
otlphttp:
traces_endpoint: "${SPLUNK_INGEST_URL}/v2/trace/otlp"
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"
# Metrics + Events
signalfx:
access_token: "${SPLUNK_ACCESS_TOKEN}"
Expand Down Expand Up @@ -123,7 +124,7 @@ service:
- batch
- resourcedetection
#- resource/add_environment
exporters: [sapm, signalfx]
exporters: [otlphttp, signalfx]
metrics:
receivers: [otlp, signalfx, awsecscontainermetrics, prometheus/internal]
processors: [memory_limiter, batch, resourcedetection]
Expand Down
9 changes: 1 addition & 8 deletions cmd/otelcol/config/collector/full_config_linux.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -647,13 +647,6 @@ exporters:
headers:
X-SF-TOKEN: "${SPLUNK_ACCESS_TOKEN}"

# Enables the sapm exporter
# Full configuration here: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/sapmexporter
# TODO: Add access token and realm
sapm:
access_token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "https://ingest.${SPLUNK_REALM}.signalfx.com/v2/trace"

# Enables the zipkin exporter
# Full configuration here: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/zipkinexporter
# NOTE: These settings should be updated to the proper destination
Expand Down Expand Up @@ -774,7 +767,7 @@ service:
- memory_limiter
- batch
#- resource/add_environment
exporters: [sapm, signalfx]
exporters: [otlphttp, signalfx]
metrics:
receivers: [otlp, signalfx]
processors: [memory_limiter, batch]
Expand Down
11 changes: 6 additions & 5 deletions cmd/otelcol/config/collector/gateway_config.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Configuration file that uses the Splunk exporters (SAPM, SignalFx) to push
# Configuration file that uses the Splunk exporters (OTLP HTTP, SignalFx) to push
# data to Splunk products.

extensions:
Expand Down Expand Up @@ -98,11 +98,12 @@ processors:

exporters:
# Traces
sapm:
access_token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "https://ingest.${SPLUNK_REALM}.signalfx.com/v2/trace"
otlphttp:
traces_endpoint: "${SPLUNK_INGEST_URL}/v2/trace/otlp"
sending_queue:
num_consumers: 32
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"
# Metrics + Events
signalfx:
access_token: "${SPLUNK_ACCESS_TOKEN}"
Expand Down Expand Up @@ -142,7 +143,7 @@ service:
- memory_limiter
- batch
#- resource/add_environment
exporters: [sapm]
exporters: [otlphttp]
metrics:
receivers: [otlp, signalfx]
processors: [memory_limiter, batch]
Expand Down
21 changes: 11 additions & 10 deletions cmd/otelcol/config/collector/upstream_agent_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,10 @@ processors:

exporters:
# Traces
sapm:
access_token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "${SPLUNK_INGEST_URL}/v2/trace"
otlphttp:
traces_endpoint: "${SPLUNK_INGEST_URL}/v2/trace/otlp"
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"
# Metrics + Events
signalfx:
access_token: "${SPLUNK_ACCESS_TOKEN}"
Expand All @@ -143,7 +144,7 @@ exporters:
endpoint: "https://ingest.${SPLUNK_REALM}.signalfx.com/v1/log"
log_data_enabled: false
# Send to gateway
otlp:
otlp/gateway:
endpoint: "${SPLUNK_GATEWAY_URL}:4317"
tls:
insecure: true
Expand All @@ -162,30 +163,30 @@ service:
- batch
- resourcedetection
#- resource/add_environment
exporters: [sapm, signalfx]
exporters: [otlphttp, signalfx]
# Use instead when sending to gateway
#exporters: [otlp, signalfx]
#exporters: [otlp/gateway, signalfx]
# Required for Splunk Infrastructure Monitoring
metrics:
receivers: [hostmetrics, otlp, signalfx]
processors: [memory_limiter, batch, resourcedetection]
exporters: [signalfx]
# Use instead when sending to gateway
#exporters: [otlp]
#exporters: [otlp/gateway]
# Required for Splunk APM and/or Infrastructure Monitoring
metrics/internal:
receivers: [prometheus/internal]
processors: [memory_limiter, batch, resourcedetection]
exporters: [signalfx]
# Use instead when sending to gateway
#exporters: [otlp]
#exporters: [otlp/gateway]
# Required for Splunk Infrastructure Monitoring
logs/signalfx:
receivers: [signalfx]
processors: [memory_limiter, batch]
exporters: [signalfx]
# Use instead when sending to gateway
#exporters: [otlp]
#exporters: [otlp/gateway]
logs/entities:
# Receivers are dynamically added if discovery mode is enabled
receivers: [nop]
Expand All @@ -201,4 +202,4 @@ service:
#- resource/add_environment
exporters: [splunk_hec/profiling]
# Use instead when sending to gateway
#exporters: [otlp]
#exporters: [otlp/gateway]
9 changes: 5 additions & 4 deletions cmd/otelcol/fips/config/agent_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,10 @@ processors:

exporters:
# Traces
sapm:
access_token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "${SPLUNK_INGEST_URL}/v2/trace"
otlphttp:
traces_endpoint: "${SPLUNK_INGEST_URL}/v2/trace/otlp"
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"
# Metrics + Events
signalfx:
access_token: "${SPLUNK_ACCESS_TOKEN}"
Expand Down Expand Up @@ -165,7 +166,7 @@ service:
- batch
- resourcedetection
#- resource/add_environment
exporters: [sapm, signalfx]
exporters: [otlphttp, signalfx]
# Use instead when sending to gateway
#exporters: [otlp, signalfx]
metrics:
Expand Down
9 changes: 5 additions & 4 deletions cmd/otelcol/fips/config/ecs_ec2_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,10 @@ processors:

exporters:
# Traces
sapm:
access_token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "https://ingest.${SPLUNK_REALM}.signalfx.com/v2/trace"
otlphttp:
traces_endpoint: "${SPLUNK_INGEST_URL}/v2/trace/otlp"
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"
# Metrics + Events
signalfx:
access_token: "${SPLUNK_ACCESS_TOKEN}"
Expand Down Expand Up @@ -142,7 +143,7 @@ service:
- batch
- resourcedetection
#- resource/add_environment
exporters: [sapm, signalfx]
exporters: [otlphttp, signalfx]
metrics:
receivers: [hostmetrics, otlp, signalfx]
processors: [memory_limiter, batch, filter, resourcedetection]
Expand Down
9 changes: 5 additions & 4 deletions cmd/otelcol/fips/config/fargate_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,10 @@ processors:

exporters:
# Traces
sapm:
access_token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "https://ingest.${SPLUNK_REALM}.signalfx.com/v2/trace"
otlphttp:
traces_endpoint: "${SPLUNK_INGEST_URL}/v2/trace/otlp"
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"
# Metrics + Events
signalfx:
access_token: "${SPLUNK_ACCESS_TOKEN}"
Expand Down Expand Up @@ -120,7 +121,7 @@ service:
- batch
- resourcedetection
#- resource/add_environment
exporters: [sapm, signalfx]
exporters: [otlphttp, signalfx]
metrics:
receivers: [otlp, signalfx, prometheus/internal]
processors: [memory_limiter, batch, resourcedetection]
Expand Down
9 changes: 5 additions & 4 deletions cmd/otelcol/fips/config/gateway_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,12 @@ processors:

exporters:
# Traces
sapm:
access_token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "https://ingest.${SPLUNK_REALM}.signalfx.com/v2/trace"
otlphttp:
traces_endpoint: "${SPLUNK_INGEST_URL}/v2/trace/otlp"
sending_queue:
num_consumers: 32
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"
# Metrics + Events
signalfx:
access_token: "${SPLUNK_ACCESS_TOKEN}"
Expand Down Expand Up @@ -136,7 +137,7 @@ service:
- memory_limiter
- batch
#- resource/add_environment
exporters: [sapm]
exporters: [otlphttp]
metrics:
receivers: [otlp, signalfx]
processors: [memory_limiter, batch]
Expand Down
9 changes: 5 additions & 4 deletions deployments/nomad/otel-agent.nomad
Original file line number Diff line number Diff line change
Expand Up @@ -201,9 +201,6 @@ processors:
override: true
timeout: 10s
exporters:
sapm:
access_token: ${SPLUNK_ACCESS_TOKEN}
endpoint: https://ingest.${SPLUNK_REALM}.signalfx.com/v2/trace
signalfx:
access_token: ${SPLUNK_ACCESS_TOKEN}
api_url: https://api.${SPLUNK_REALM}.signalfx.com
Expand All @@ -212,6 +209,10 @@ exporters:
sync_host_metadata: true
debug:
verbosity: detailed
otlphttp:
traces_endpoint: "https://ingest.${SPLUNK_REALM}.signalfx.com/v2/trace/otlp"
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"
service:
extensions:
- health_check
Expand Down Expand Up @@ -241,7 +242,7 @@ service:
traces:
exporters:
- debug
- sapm
- otlphttp
- signalfx
processors:
- memory_limiter
Expand Down
Loading
Loading